You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by anoopsharma00 <gi...@git.apache.org> on 2017/05/10 19:19:02 UTC
[GitHub] incubator-trafodion pull request #1090: TRAFODION-2610 Register native HBase...
GitHub user anoopsharma00 opened a pull request:
https://github.com/apache/incubator-trafodion/pull/1090
TRAFODION-2610 Register native HBase tables in traf MD plus HB Mapped table fixes
-- support for registering hbase native cell/row format tables in traf MD
Syntax:
register [internal] hbase table [if not exists] <table-name>
unregister [internal] hbase table [if exists] <table-name>
-- support to get info related to registered hbase tables
Syntax: get hbase registered table in catalog trafodion
-- enhancements to HBase mapped tables and bug fixes
-- disabling of creation of external tables on native hbase
tables unless they are mapped tables
-- support for case-insensitive format string in TO_DATE function
(exp/exp_datetime.h)
-- regress/seabase/TEST022 enhanced with additional tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anoopsharma00/incubator-trafodion ansharma_hbasereg_deliver_br
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/1090.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1090
----
commit 6ffe0b5b6097ab503965f40734ba7f0275892f01
Author: Anoop Sharma <an...@esgyn.com>
Date: 2017-05-10T19:16:18Z
TRAFODION-2610 Register native HBase tables in traf MD plus couple more
-- support for registering hbase native cell/row format tables in traf MD
Syntax:
register [internal] hbase table [if not exists] <table-name>
unregister [internal] hbase table [if exists] <table-name>
-- support to get info related to registered hbase tables
Syntax: get hbase registered table in catalog trafodion
-- enhancements to HBase mapped tables and bug fixes
-- disabling of creation of external tables on native hbase
tables unless they are mapped tables
-- support for case-insensitive format string in TO_DATE function
(exp/exp_datetime.h)
-- regress/seabase/TEST022 enhanced with additional tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1090: TRAFODION-2610 Register native HBase...
Posted by anoopsharma00 <gi...@git.apache.org>.
Github user anoopsharma00 commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1090#discussion_r116369510
--- Diff: core/sql/regress/hive/EXPECTED007 ---
@@ -353,9 +355,7 @@ A B
>>unregister hive table if exists hive.hive.thive1;
-*** ERROR[4263] Object HIVE.HIVE.THIVE1 has invalid state and cannot be accessed. It is registered in trafodion metadata but the correponding hive object does not exist. Use 'cleanup hive table/view' command to cleanup this object.
-
-*** ERROR[3251] UNREGISTER operation could not be completed.
+*** ERROR[3251] UNREGISTER operation could not be completed. Reason: Specified object THIVE1 does not exist.
--- End diff --
Good eye.
The error message is incorrect. It should return error that table has invalid state and need to be cleaned up.
Check for 'if exists' only apply to tables with valid state.
Will fix this in a subsequent release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1090: TRAFODION-2610 Register native HBase...
Posted by anoopsharma00 <gi...@git.apache.org>.
Github user anoopsharma00 commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1090#discussion_r116369158
--- Diff: core/sql/regress/seabase/EXPECTED030 ---
@@ -7,7 +7,7 @@
2016-03-01
--- 1 row(s) selected.
->>select to_date('03/01/2016', 'MM/DD/YYYY') from (values(1)) x(a);
+>>select to_date('03/01/2016', 'mm/dd/yyyy') from (values(1)) x(a);
--- End diff --
yes, all TO_DATE formats are now case-insensitive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1090: TRAFODION-2610 Register native HBase...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/1090
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1090: TRAFODION-2610 Register native HBase...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1090#discussion_r116121098
--- Diff: core/sql/regress/hive/EXPECTED007 ---
@@ -353,9 +355,7 @@ A B
>>unregister hive table if exists hive.hive.thive1;
-*** ERROR[4263] Object HIVE.HIVE.THIVE1 has invalid state and cannot be accessed. It is registered in trafodion metadata but the correponding hive object does not exist. Use 'cleanup hive table/view' command to cleanup this object.
-
-*** ERROR[3251] UNREGISTER operation could not be completed.
+*** ERROR[3251] UNREGISTER operation could not be completed. Reason: Specified object THIVE1 does not exist.
--- End diff --
Why would this be an error since you specified "if exists"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1090: TRAFODION-2610 Register native HBase...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1090#discussion_r116121682
--- Diff: core/sql/regress/seabase/EXPECTED030 ---
@@ -7,7 +7,7 @@
2016-03-01
--- 1 row(s) selected.
->>select to_date('03/01/2016', 'MM/DD/YYYY') from (values(1)) x(a);
+>>select to_date('03/01/2016', 'mm/dd/yyyy') from (values(1)) x(a);
--- End diff --
Does "ddmonyy" also work in lower case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---