You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shardingsphere.apache.org by Zheng Feng <zh...@apache.org> on 2023/01/11 12:18:08 UTC
[DISCUSS] Plan to drop support for JDK 8
Hi all,
This thought is coming from upgrading antlr to 4.10.1 [1] which is only for
Java 11 now. Currently it looks like that the Hibernate 6.0.x [2] and
Quarkus 2.15.x [3] integrations has been blocked by this upgrading issue.
I think it could be some other 3rd party libraries with this similar issue
sooner or later. So it is time to think about the plan to drop JDK 8 in
shardingsphere now.
I know this is BIG breaking change that could impact a lot of people who
use the shardingsphere. Also it is not very clear in current roadmap [4]
and the document for support JDKs.
So my plan is to keep 5.x branch which sticks to JDK 8 and should be a LTS
version (I'm not sure how long we will be like to support it?). Then bump
the master branch to 6.0 to drop JDK 8 support as soon as possible. There
will be a little bit much more maintenance works with 5.x and master
branches.
What the others think? and we definitely need a formal voting process for
this plan after this discussion.
Regards,
Zheng Feng
[1] https://github.com/antlr/antlr4/releases/tag/4.10.1
[2] https://github.com/apache/shardingsphere/pull/20119
[3] https://github.com/quarkiverse/quarkus-shardingsphere-jdbc/issues/84
[4] https://shardingsphere.apache.org/document/current/en/overview/#roadmap
Re:Re: [DISCUSS] Plan to drop support for JDK 8
Posted by KimmKing <ki...@apache.org>.
Because of more Applications running in JDK8 rather than JDK11+, I think dropping support for JDK 8 is a little early now.
--
Kimm King(kimmking@apache.org/kimmking@163.com)
Apache Dubbo&ShardingSphere PMC Member
github&twitter: kimmking
在 2023-01-14 00:35:27，"Zheng Feng" <zh...@gmail.com> 写道：
>I raise to a PR [1] to force build on JDK 11 and hope it could resolve the
>antlr upgrading issue.
>
>[1] https://github.com/apache/shardingsphere/pull/23550
>
>Sheng Wu <wu...@gmail.com> 于2023年1月13日周五 21:38写道：
>
>> Personally, I don't have concern about compiling JDK version. This is a
>> more dev relative thing.
>>
>> Zheng Feng <zh...@gmail.com>于2023年1月13日 周五21:31写道：
>>
>> > OK, I can understand. Back to resolve antlr4 upgrading issue [1], I'm
>> > trying to figure it out since this only impact generating some parsers at
>> > build time. The only way is to use JDK11 to build the shardingsphere but
>> > still target for JDK 8 by using
>> > "<maven.compiler.release>8</maven.compiler.release>" [2]. So is it
>> feasible
>> > for the community to accept this solution? Just changing enforcer-plugin
>> to
>> > requireJavaVersion 11?
>> >
>> > [1] https://github.com/apache/shardingsphere/pull/20008
>> > [2]
>> >
>> >
>> https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html
>> >
>> > Sheng Wu <wu...@gmail.com> 于2023年1月13日周五 21:16写道：
>> >
>> > > Zheng Feng <zh...@gmail.com> 于2023年1月13日周五 21:04写道：
>> > > >
>> > > > I'm not pushing to drop JDK 8 now but I wonder if it is possible to
>> > > > maintain two LTS versions of shardingsphere. e.g. 5.x for JDK 8 and
>> 6.x
>> > > for
>> > > > JDK 11 above.
>> > >
>> > > New features end, from my understanding, this is the end of support of
>> > > JDK8.
>> > > Maintaining mode is only about high-priority bug fixing, and no
>> > > enhancement, no new feature, no performance improvement.
>> > > With time, many things can't cherry-pick back to the JDK 8.
>> > >
>> > > >
>> > > > Sheng Wu <wu...@gmail.com> 于2023年1月13日周五 20:58写道：
>> > > >
>> > > > > From my side, only if there are key improvements for JDK 11, we are
>> > > > > worth taking that risk. Especially, whether these things are JDK 11
>> > > > > compiling only.
>> > > > > SkyWalking chose to use ShardingSphere proxy, but we discussed the
>> > > > > possibilities of ShardingJDBC, but if we made that choice(JDBC
>> lib),
>> > > > > this change would totally make SkyWalking no choice but to stay in
>> > the
>> > > > > old release or remove this feature.
>> > > > >
>> > > > > This will be many of our end users' position if we announce that.
>> > > > >
>> > > > > JDK 8 actually has a longer LTS than JDK 11. JDK 8 - At least Nov
>> > > > > 2026, JDK 11 - At least Oct 2024
>> > > > > Source from Temurin(was, OpenJDK) https://adoptium.net/support/
>> > > > >
>> > > > > It will surprise everyone, ShardingSphere community removed the
>> > > > > primary and widely used JDK version, and move on to another
>> > > > > dead-earlier version :(
>> > > > >
>> > > > > If this is a vote for the future, I would say -1.
>> > > > >
>> > > > >
>> > > > > Sheng Wu 吴晟
>> > > > > Twitter, wusheng1108
>> > > > >
>> > > > > Zheng Feng <zh...@gmail.com> 于2023年1月13日周五 16:54写道：
>> > > > > >
>> > > > > > Yeah, I understand your concern for supporting the legacy
>> > > applications
>> > > > > > especially for such users who have been using it in the
>> production
>> > > > > > environment. But from the point of innovation, I think it would
>> be
>> > > great
>> > > > > to
>> > > > > > use the latest JDK which has many new impressive features. And
>> > > sooner or
>> > > > > > later, we still have to face the problem of dropping JDK 8. So
>> why
>> > > don't
>> > > > > we
>> > > > > > consider it for now?
>> > > > > >
>> > > > > > I don't think 200+ modules is a BIG problem for maintaining work.
>> > > You can
>> > > > > > see Apache camel which has 500+ modules but still supports 3 LTS
>> > > > > versions.
>> > > > > >
>> > > > > > There could be some way to help us to do backporting work such as
>> > > using a
>> > > > > > github bot.
>> > > > > >
>> > > > > > Anway, I also think it would be an opportunity to think about the
>> > > RoadMap
>> > > > > > of shardingsphere.
>> > > > > >
>> > > > > > Thanks,
>> > > > > > Zheng Feng
>> > > > > >
>> > > > > > zhangliang@apache.org <zh...@apache.org> 于2023年1月13日周五
>> > 14:42写道：
>> > > > > >
>> > > > > > > There are lots of legacy applications still using Java 8.
>> > > > > > > ShardingSphere-JDBC is a java lib, not standalone process, the
>> > LTS
>> > > of
>> > > > > Java
>> > > > > > > 8 is necessary.
>> > > > > > >
>> > > > > > > But there are 200+ modules in ShardingSphere, so I am afraid
>> > nobody
>> > > > > > > can undertake the costs of maintain 2 different versions.
>> > > > > > >
>> > > > > > > ------------------
>> > > > > > >
>> > > > > > > Sincerely,
>> > > > > > > Liang Zhang (John)
>> > > > > > > Apache ShardingSphere
>> > > > > > >
>> > > > > > >
>> > > > > > > 吴伟杰 <wu...@apache.org> 于2023年1月12日周四 10:57写道：
>> > > > > > >
>> > > > > > > > I also want to use the Java 11 or 17.
>> > > > > > > > We have had to do some special handling in codes to avoid
>> > > performance
>> > > > > > > > issues in Java 8 (such as JDK-8161372 [1]).
>> > > > > > > >
>> > > > > > > > [1] https://bugs.openjdk.java.net/browse/JDK-8161372
>> > > > > > > >
>> > > > > > > > Regards,
>> > > > > > > > Weijie
>> > > > > > > > -----------------------------------------------
>> > > > > > > >
>> > > > > > > > Wu Weijie 吴伟杰
>> > > > > > > > Apache ShardingSphere PMC
>> > > > > > > > GitHub@TeslaCN
>> > > > > > > >
>> > > > > > > > Zheng Feng <zh...@apache.org> 于2023年1月11日周三 20:18写道：
>> > > > > > > >
>> > > > > > > > >
>> > > > > > > > > Hi all,
>> > > > > > > > >
>> > > > > > > > > This thought is coming from upgrading antlr to 4.10.1 [1]
>> > > which is
>> > > > > only
>> > > > > > > > for
>> > > > > > > > > Java 11 now. Currently it looks like that the Hibernate
>> 6.0.x
>> > > [2]
>> > > > > and
>> > > > > > > > > Quarkus 2.15.x [3] integrations has been blocked by this
>> > > upgrading
>> > > > > > > issue.
>> > > > > > > > >
>> > > > > > > > > I think it could be some other 3rd party libraries with
>> this
>> > > > > similar
>> > > > > > > > issue
>> > > > > > > > > sooner or later. So it is time to think about the plan to
>> > drop
>> > > JDK
>> > > > > 8 in
>> > > > > > > > > shardingsphere now.
>> > > > > > > > >
>> > > > > > > > > I know this is BIG breaking change that could impact a lot
>> of
>> > > > > people
>> > > > > > > who
>> > > > > > > > > use the shardingsphere. Also it is not very clear in
>> current
>> > > > > roadmap
>> > > > > > > [4]
>> > > > > > > > > and the document for support JDKs.
>> > > > > > > > >
>> > > > > > > > > So my plan is to keep 5.x branch which sticks to JDK 8 and
>> > > should
>> > > > > be a
>> > > > > > > > LTS
>> > > > > > > > > version (I'm not sure how long we will be like to support
>> > it?).
>> > > > > Then
>> > > > > > > bump
>> > > > > > > > > the master branch to 6.0 to drop JDK 8 support as soon as
>> > > possible.
>> > > > > > > There
>> > > > > > > > > will be a little bit much more maintenance works with 5.x
>> and
>> > > > > master
>> > > > > > > > > branches.
>> > > > > > > > >
>> > > > > > > > > What the others think? and we definitely need a formal
>> voting
>> > > > > process
>> > > > > > > for
>> > > > > > > > > this plan after this discussion.
>> > > > > > > > >
>> > > > > > > > > Regards,
>> > > > > > > > > Zheng Feng
>> > > > > > > > >
>> > > > > > > > > [1] https://github.com/antlr/antlr4/releases/tag/4.10.1
>> > > > > > > > > [2] https://github.com/apache/shardingsphere/pull/20119
>> > > > > > > > > [3]
>> > > > > > >
>> > > https://github.com/quarkiverse/quarkus-shardingsphere-jdbc/issues/84
>> > > > > > > > > [4]
>> > > > > > > >
>> > > > >
>> > >
>> https://shardingsphere.apache.org/document/current/en/overview/#roadmap
>> > > > > > > >
>> > > > > > >
>> > > > >
>> > >
>> >
>> --
>> Sheng Wu 吴晟
>>
>> Apache SkyWalking
>> Apache Incubator
>> Apache ShardingSphere, ECharts, DolphinScheduler podlings
>> Zipkin
>> Twitter, wusheng1108
>>
Re: [DISCUSS] Plan to drop support for JDK 8
Posted by Zheng Feng <zh...@gmail.com>.
I raise to a PR [1] to force build on JDK 11 and hope it could resolve the
antlr upgrading issue.
[1] https://github.com/apache/shardingsphere/pull/23550
Sheng Wu <wu...@gmail.com> 于2023年1月13日周五 21:38写道：
> Personally, I don't have concern about compiling JDK version. This is a
> more dev relative thing.
>
> Zheng Feng <zh...@gmail.com>于2023年1月13日 周五21:31写道：
>
> > OK, I can understand. Back to resolve antlr4 upgrading issue [1], I'm
> > trying to figure it out since this only impact generating some parsers at
> > build time. The only way is to use JDK11 to build the shardingsphere but
> > still target for JDK 8 by using
> > "<maven.compiler.release>8</maven.compiler.release>" [2]. So is it
> feasible
> > for the community to accept this solution? Just changing enforcer-plugin
> to
> > requireJavaVersion 11?
> >
> > [1] https://github.com/apache/shardingsphere/pull/20008
> > [2]
> >
> >
> https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html
> >
> > Sheng Wu <wu...@gmail.com> 于2023年1月13日周五 21:16写道：
> >
> > > Zheng Feng <zh...@gmail.com> 于2023年1月13日周五 21:04写道：
> > > >
> > > > I'm not pushing to drop JDK 8 now but I wonder if it is possible to
> > > > maintain two LTS versions of shardingsphere. e.g. 5.x for JDK 8 and
> 6.x
> > > for
> > > > JDK 11 above.
> > >
> > > New features end, from my understanding, this is the end of support of
> > > JDK8.
> > > Maintaining mode is only about high-priority bug fixing, and no
> > > enhancement, no new feature, no performance improvement.
> > > With time, many things can't cherry-pick back to the JDK 8.
> > >
> > > >
> > > > Sheng Wu <wu...@gmail.com> 于2023年1月13日周五 20:58写道：
> > > >
> > > > > From my side, only if there are key improvements for JDK 11, we are
> > > > > worth taking that risk. Especially, whether these things are JDK 11
> > > > > compiling only.
> > > > > SkyWalking chose to use ShardingSphere proxy, but we discussed the
> > > > > possibilities of ShardingJDBC, but if we made that choice(JDBC
> lib),
> > > > > this change would totally make SkyWalking no choice but to stay in
> > the
> > > > > old release or remove this feature.
> > > > >
> > > > > This will be many of our end users' position if we announce that.
> > > > >
> > > > > JDK 8 actually has a longer LTS than JDK 11. JDK 8 - At least Nov
> > > > > 2026, JDK 11 - At least Oct 2024
> > > > > Source from Temurin(was, OpenJDK) https://adoptium.net/support/
> > > > >
> > > > > It will surprise everyone, ShardingSphere community removed the
> > > > > primary and widely used JDK version, and move on to another
> > > > > dead-earlier version :(
> > > > >
> > > > > If this is a vote for the future, I would say -1.
> > > > >
> > > > >
> > > > > Sheng Wu 吴晟
> > > > > Twitter, wusheng1108
> > > > >
> > > > > Zheng Feng <zh...@gmail.com> 于2023年1月13日周五 16:54写道：
> > > > > >
> > > > > > Yeah, I understand your concern for supporting the legacy
> > > applications
> > > > > > especially for such users who have been using it in the
> production
> > > > > > environment. But from the point of innovation, I think it would
> be
> > > great
> > > > > to
> > > > > > use the latest JDK which has many new impressive features. And
> > > sooner or
> > > > > > later, we still have to face the problem of dropping JDK 8. So
> why
> > > don't
> > > > > we
> > > > > > consider it for now?
> > > > > >
> > > > > > I don't think 200+ modules is a BIG problem for maintaining work.
> > > You can
> > > > > > see Apache camel which has 500+ modules but still supports 3 LTS
> > > > > versions.
> > > > > >
> > > > > > There could be some way to help us to do backporting work such as
> > > using a
> > > > > > github bot.
> > > > > >
> > > > > > Anway, I also think it would be an opportunity to think about the
> > > RoadMap
> > > > > > of shardingsphere.
> > > > > >
> > > > > > Thanks,
> > > > > > Zheng Feng
> > > > > >
> > > > > > zhangliang@apache.org <zh...@apache.org> 于2023年1月13日周五
> > 14:42写道：
> > > > > >
> > > > > > > There are lots of legacy applications still using Java 8.
> > > > > > > ShardingSphere-JDBC is a java lib, not standalone process, the
> > LTS
> > > of
> > > > > Java
> > > > > > > 8 is necessary.
> > > > > > >
> > > > > > > But there are 200+ modules in ShardingSphere, so I am afraid
> > nobody
> > > > > > > can undertake the costs of maintain 2 different versions.
> > > > > > >
> > > > > > > ------------------
> > > > > > >
> > > > > > > Sincerely,
> > > > > > > Liang Zhang (John)
> > > > > > > Apache ShardingSphere
> > > > > > >
> > > > > > >
> > > > > > > 吴伟杰 <wu...@apache.org> 于2023年1月12日周四 10:57写道：
> > > > > > >
> > > > > > > > I also want to use the Java 11 or 17.
> > > > > > > > We have had to do some special handling in codes to avoid
> > > performance
> > > > > > > > issues in Java 8 (such as JDK-8161372 [1]).
> > > > > > > >
> > > > > > > > [1] https://bugs.openjdk.java.net/browse/JDK-8161372
> > > > > > > >
> > > > > > > > Regards,
> > > > > > > > Weijie
> > > > > > > > -----------------------------------------------
> > > > > > > >
> > > > > > > > Wu Weijie 吴伟杰
> > > > > > > > Apache ShardingSphere PMC
> > > > > > > > GitHub@TeslaCN
> > > > > > > >
> > > > > > > > Zheng Feng <zh...@apache.org> 于2023年1月11日周三 20:18写道：
> > > > > > > >
> > > > > > > > >
> > > > > > > > > Hi all,
> > > > > > > > >
> > > > > > > > > This thought is coming from upgrading antlr to 4.10.1 [1]
> > > which is
> > > > > only
> > > > > > > > for
> > > > > > > > > Java 11 now. Currently it looks like that the Hibernate
> 6.0.x
> > > [2]
> > > > > and
> > > > > > > > > Quarkus 2.15.x [3] integrations has been blocked by this
> > > upgrading
> > > > > > > issue.
> > > > > > > > >
> > > > > > > > > I think it could be some other 3rd party libraries with
> this
> > > > > similar
> > > > > > > > issue
> > > > > > > > > sooner or later. So it is time to think about the plan to
> > drop
> > > JDK
> > > > > 8 in
> > > > > > > > > shardingsphere now.
> > > > > > > > >
> > > > > > > > > I know this is BIG breaking change that could impact a lot
> of
> > > > > people
> > > > > > > who
> > > > > > > > > use the shardingsphere. Also it is not very clear in
> current
> > > > > roadmap
> > > > > > > [4]
> > > > > > > > > and the document for support JDKs.
> > > > > > > > >
> > > > > > > > > So my plan is to keep 5.x branch which sticks to JDK 8 and
> > > should
> > > > > be a
> > > > > > > > LTS
> > > > > > > > > version (I'm not sure how long we will be like to support
> > it?).
> > > > > Then
> > > > > > > bump
> > > > > > > > > the master branch to 6.0 to drop JDK 8 support as soon as
> > > possible.
> > > > > > > There
> > > > > > > > > will be a little bit much more maintenance works with 5.x
> and
> > > > > master
> > > > > > > > > branches.
> > > > > > > > >
> > > > > > > > > What the others think? and we definitely need a formal
> voting
> > > > > process
> > > > > > > for
> > > > > > > > > this plan after this discussion.
> > > > > > > > >
> > > > > > > > > Regards,
> > > > > > > > > Zheng Feng
> > > > > > > > >
> > > > > > > > > [1] https://github.com/antlr/antlr4/releases/tag/4.10.1
> > > > > > > > > [2] https://github.com/apache/shardingsphere/pull/20119
> > > > > > > > > [3]
> > > > > > >
> > > https://github.com/quarkiverse/quarkus-shardingsphere-jdbc/issues/84
> > > > > > > > > [4]
> > > > > > > >
> > > > >
> > >
> https://shardingsphere.apache.org/document/current/en/overview/#roadmap
> > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> --
> Sheng Wu 吴晟
>
> Apache SkyWalking
> Apache Incubator
> Apache ShardingSphere, ECharts, DolphinScheduler podlings
> Zipkin
> Twitter, wusheng1108
>
Re: [DISCUSS] Plan to drop support for JDK 8
Posted by Sheng Wu <wu...@gmail.com>.
Personally, I don't have concern about compiling JDK version. This is a
more dev relative thing.
Zheng Feng <zh...@gmail.com>于2023年1月13日 周五21:31写道：
> OK, I can understand. Back to resolve antlr4 upgrading issue [1], I'm
> trying to figure it out since this only impact generating some parsers at
> build time. The only way is to use JDK11 to build the shardingsphere but
> still target for JDK 8 by using
> "<maven.compiler.release>8</maven.compiler.release>" [2]. So is it feasible
> for the community to accept this solution? Just changing enforcer-plugin to
> requireJavaVersion 11?
>
> [1] https://github.com/apache/shardingsphere/pull/20008
> [2]
>
> https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html
>
> Sheng Wu <wu...@gmail.com> 于2023年1月13日周五 21:16写道：
>
> > Zheng Feng <zh...@gmail.com> 于2023年1月13日周五 21:04写道：
> > >
> > > I'm not pushing to drop JDK 8 now but I wonder if it is possible to
> > > maintain two LTS versions of shardingsphere. e.g. 5.x for JDK 8 and 6.x
> > for
> > > JDK 11 above.
> >
> > New features end, from my understanding, this is the end of support of
> > JDK8.
> > Maintaining mode is only about high-priority bug fixing, and no
> > enhancement, no new feature, no performance improvement.
> > With time, many things can't cherry-pick back to the JDK 8.
> >
> > >
> > > Sheng Wu <wu...@gmail.com> 于2023年1月13日周五 20:58写道：
> > >
> > > > From my side, only if there are key improvements for JDK 11, we are
> > > > worth taking that risk. Especially, whether these things are JDK 11
> > > > compiling only.
> > > > SkyWalking chose to use ShardingSphere proxy, but we discussed the
> > > > possibilities of ShardingJDBC, but if we made that choice(JDBC lib),
> > > > this change would totally make SkyWalking no choice but to stay in
> the
> > > > old release or remove this feature.
> > > >
> > > > This will be many of our end users' position if we announce that.
> > > >
> > > > JDK 8 actually has a longer LTS than JDK 11. JDK 8 - At least Nov
> > > > 2026, JDK 11 - At least Oct 2024
> > > > Source from Temurin(was, OpenJDK) https://adoptium.net/support/
> > > >
> > > > It will surprise everyone, ShardingSphere community removed the
> > > > primary and widely used JDK version, and move on to another
> > > > dead-earlier version :(
> > > >
> > > > If this is a vote for the future, I would say -1.
> > > >
> > > >
> > > > Sheng Wu 吴晟
> > > > Twitter, wusheng1108
> > > >
> > > > Zheng Feng <zh...@gmail.com> 于2023年1月13日周五 16:54写道：
> > > > >
> > > > > Yeah, I understand your concern for supporting the legacy
> > applications
> > > > > especially for such users who have been using it in the production
> > > > > environment. But from the point of innovation, I think it would be
> > great
> > > > to
> > > > > use the latest JDK which has many new impressive features. And
> > sooner or
> > > > > later, we still have to face the problem of dropping JDK 8. So why
> > don't
> > > > we
> > > > > consider it for now?
> > > > >
> > > > > I don't think 200+ modules is a BIG problem for maintaining work.
> > You can
> > > > > see Apache camel which has 500+ modules but still supports 3 LTS
> > > > versions.
> > > > >
> > > > > There could be some way to help us to do backporting work such as
> > using a
> > > > > github bot.
> > > > >
> > > > > Anway, I also think it would be an opportunity to think about the
> > RoadMap
> > > > > of shardingsphere.
> > > > >
> > > > > Thanks,
> > > > > Zheng Feng
> > > > >
> > > > > zhangliang@apache.org <zh...@apache.org> 于2023年1月13日周五
> 14:42写道：
> > > > >
> > > > > > There are lots of legacy applications still using Java 8.
> > > > > > ShardingSphere-JDBC is a java lib, not standalone process, the
> LTS
> > of
> > > > Java
> > > > > > 8 is necessary.
> > > > > >
> > > > > > But there are 200+ modules in ShardingSphere, so I am afraid
> nobody
> > > > > > can undertake the costs of maintain 2 different versions.
> > > > > >
> > > > > > ------------------
> > > > > >
> > > > > > Sincerely,
> > > > > > Liang Zhang (John)
> > > > > > Apache ShardingSphere
> > > > > >
> > > > > >
> > > > > > 吴伟杰 <wu...@apache.org> 于2023年1月12日周四 10:57写道：
> > > > > >
> > > > > > > I also want to use the Java 11 or 17.
> > > > > > > We have had to do some special handling in codes to avoid
> > performance
> > > > > > > issues in Java 8 (such as JDK-8161372 [1]).
> > > > > > >
> > > > > > > [1] https://bugs.openjdk.java.net/browse/JDK-8161372
> > > > > > >
> > > > > > > Regards,
> > > > > > > Weijie
> > > > > > > -----------------------------------------------
> > > > > > >
> > > > > > > Wu Weijie 吴伟杰
> > > > > > > Apache ShardingSphere PMC
> > > > > > > GitHub@TeslaCN
> > > > > > >
> > > > > > > Zheng Feng <zh...@apache.org> 于2023年1月11日周三 20:18写道：
> > > > > > >
> > > > > > > >
> > > > > > > > Hi all,
> > > > > > > >
> > > > > > > > This thought is coming from upgrading antlr to 4.10.1 [1]
> > which is
> > > > only
> > > > > > > for
> > > > > > > > Java 11 now. Currently it looks like that the Hibernate 6.0.x
> > [2]
> > > > and
> > > > > > > > Quarkus 2.15.x [3] integrations has been blocked by this
> > upgrading
> > > > > > issue.
> > > > > > > >
> > > > > > > > I think it could be some other 3rd party libraries with this
> > > > similar
> > > > > > > issue
> > > > > > > > sooner or later. So it is time to think about the plan to
> drop
> > JDK
> > > > 8 in
> > > > > > > > shardingsphere now.
> > > > > > > >
> > > > > > > > I know this is BIG breaking change that could impact a lot of
> > > > people
> > > > > > who
> > > > > > > > use the shardingsphere. Also it is not very clear in current
> > > > roadmap
> > > > > > [4]
> > > > > > > > and the document for support JDKs.
> > > > > > > >
> > > > > > > > So my plan is to keep 5.x branch which sticks to JDK 8 and
> > should
> > > > be a
> > > > > > > LTS
> > > > > > > > version (I'm not sure how long we will be like to support
> it?).
> > > > Then
> > > > > > bump
> > > > > > > > the master branch to 6.0 to drop JDK 8 support as soon as
> > possible.
> > > > > > There
> > > > > > > > will be a little bit much more maintenance works with 5.x and
> > > > master
> > > > > > > > branches.
> > > > > > > >
> > > > > > > > What the others think? and we definitely need a formal voting
> > > > process
> > > > > > for
> > > > > > > > this plan after this discussion.
> > > > > > > >
> > > > > > > > Regards,
> > > > > > > > Zheng Feng
> > > > > > > >
> > > > > > > > [1] https://github.com/antlr/antlr4/releases/tag/4.10.1
> > > > > > > > [2] https://github.com/apache/shardingsphere/pull/20119
> > > > > > > > [3]
> > > > > >
> > https://github.com/quarkiverse/quarkus-shardingsphere-jdbc/issues/84
> > > > > > > > [4]
> > > > > > >
> > > >
> > https://shardingsphere.apache.org/document/current/en/overview/#roadmap
> > > > > > >
> > > > > >
> > > >
> >
>
--
Sheng Wu 吴晟
Apache SkyWalking
Apache Incubator
Apache ShardingSphere, ECharts, DolphinScheduler podlings
Zipkin
Twitter, wusheng1108
Re: [DISCUSS] Plan to drop support for JDK 8
Posted by Zheng Feng <zh...@gmail.com>.
OK, I can understand. Back to resolve antlr4 upgrading issue [1], I'm
trying to figure it out since this only impact generating some parsers at
build time. The only way is to use JDK11 to build the shardingsphere but
still target for JDK 8 by using
"<maven.compiler.release>8</maven.compiler.release>" [2]. So is it feasible
for the community to accept this solution? Just changing enforcer-plugin to
requireJavaVersion 11?
[1] https://github.com/apache/shardingsphere/pull/20008
[2]
https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html
Sheng Wu <wu...@gmail.com> 于2023年1月13日周五 21:16写道：
> Zheng Feng <zh...@gmail.com> 于2023年1月13日周五 21:04写道：
> >
> > I'm not pushing to drop JDK 8 now but I wonder if it is possible to
> > maintain two LTS versions of shardingsphere. e.g. 5.x for JDK 8 and 6.x
> for
> > JDK 11 above.
>
> New features end, from my understanding, this is the end of support of
> JDK8.
> Maintaining mode is only about high-priority bug fixing, and no
> enhancement, no new feature, no performance improvement.
> With time, many things can't cherry-pick back to the JDK 8.
>
> >
> > Sheng Wu <wu...@gmail.com> 于2023年1月13日周五 20:58写道：
> >
> > > From my side, only if there are key improvements for JDK 11, we are
> > > worth taking that risk. Especially, whether these things are JDK 11
> > > compiling only.
> > > SkyWalking chose to use ShardingSphere proxy, but we discussed the
> > > possibilities of ShardingJDBC, but if we made that choice(JDBC lib),
> > > this change would totally make SkyWalking no choice but to stay in the
> > > old release or remove this feature.
> > >
> > > This will be many of our end users' position if we announce that.
> > >
> > > JDK 8 actually has a longer LTS than JDK 11. JDK 8 - At least Nov
> > > 2026, JDK 11 - At least Oct 2024
> > > Source from Temurin(was, OpenJDK) https://adoptium.net/support/
> > >
> > > It will surprise everyone, ShardingSphere community removed the
> > > primary and widely used JDK version, and move on to another
> > > dead-earlier version :(
> > >
> > > If this is a vote for the future, I would say -1.
> > >
> > >
> > > Sheng Wu 吴晟
> > > Twitter, wusheng1108
> > >
> > > Zheng Feng <zh...@gmail.com> 于2023年1月13日周五 16:54写道：
> > > >
> > > > Yeah, I understand your concern for supporting the legacy
> applications
> > > > especially for such users who have been using it in the production
> > > > environment. But from the point of innovation, I think it would be
> great
> > > to
> > > > use the latest JDK which has many new impressive features. And
> sooner or
> > > > later, we still have to face the problem of dropping JDK 8. So why
> don't
> > > we
> > > > consider it for now?
> > > >
> > > > I don't think 200+ modules is a BIG problem for maintaining work.
> You can
> > > > see Apache camel which has 500+ modules but still supports 3 LTS
> > > versions.
> > > >
> > > > There could be some way to help us to do backporting work such as
> using a
> > > > github bot.
> > > >
> > > > Anway, I also think it would be an opportunity to think about the
> RoadMap
> > > > of shardingsphere.
> > > >
> > > > Thanks,
> > > > Zheng Feng
> > > >
> > > > zhangliang@apache.org <zh...@apache.org> 于2023年1月13日周五 14:42写道：
> > > >
> > > > > There are lots of legacy applications still using Java 8.
> > > > > ShardingSphere-JDBC is a java lib, not standalone process, the LTS
> of
> > > Java
> > > > > 8 is necessary.
> > > > >
> > > > > But there are 200+ modules in ShardingSphere, so I am afraid nobody
> > > > > can undertake the costs of maintain 2 different versions.
> > > > >
> > > > > ------------------
> > > > >
> > > > > Sincerely,
> > > > > Liang Zhang (John)
> > > > > Apache ShardingSphere
> > > > >
> > > > >
> > > > > 吴伟杰 <wu...@apache.org> 于2023年1月12日周四 10:57写道：
> > > > >
> > > > > > I also want to use the Java 11 or 17.
> > > > > > We have had to do some special handling in codes to avoid
> performance
> > > > > > issues in Java 8 (such as JDK-8161372 [1]).
> > > > > >
> > > > > > [1] https://bugs.openjdk.java.net/browse/JDK-8161372
> > > > > >
> > > > > > Regards,
> > > > > > Weijie
> > > > > > -----------------------------------------------
> > > > > >
> > > > > > Wu Weijie 吴伟杰
> > > > > > Apache ShardingSphere PMC
> > > > > > GitHub@TeslaCN
> > > > > >
> > > > > > Zheng Feng <zh...@apache.org> 于2023年1月11日周三 20:18写道：
> > > > > >
> > > > > > >
> > > > > > > Hi all,
> > > > > > >
> > > > > > > This thought is coming from upgrading antlr to 4.10.1 [1]
> which is
> > > only
> > > > > > for
> > > > > > > Java 11 now. Currently it looks like that the Hibernate 6.0.x
> [2]
> > > and
> > > > > > > Quarkus 2.15.x [3] integrations has been blocked by this
> upgrading
> > > > > issue.
> > > > > > >
> > > > > > > I think it could be some other 3rd party libraries with this
> > > similar
> > > > > > issue
> > > > > > > sooner or later. So it is time to think about the plan to drop
> JDK
> > > 8 in
> > > > > > > shardingsphere now.
> > > > > > >
> > > > > > > I know this is BIG breaking change that could impact a lot of
> > > people
> > > > > who
> > > > > > > use the shardingsphere. Also it is not very clear in current
> > > roadmap
> > > > > [4]
> > > > > > > and the document for support JDKs.
> > > > > > >
> > > > > > > So my plan is to keep 5.x branch which sticks to JDK 8 and
> should
> > > be a
> > > > > > LTS
> > > > > > > version (I'm not sure how long we will be like to support it?).
> > > Then
> > > > > bump
> > > > > > > the master branch to 6.0 to drop JDK 8 support as soon as
> possible.
> > > > > There
> > > > > > > will be a little bit much more maintenance works with 5.x and
> > > master
> > > > > > > branches.
> > > > > > >
> > > > > > > What the others think? and we definitely need a formal voting
> > > process
> > > > > for
> > > > > > > this plan after this discussion.
> > > > > > >
> > > > > > > Regards,
> > > > > > > Zheng Feng
> > > > > > >
> > > > > > > [1] https://github.com/antlr/antlr4/releases/tag/4.10.1
> > > > > > > [2] https://github.com/apache/shardingsphere/pull/20119
> > > > > > > [3]
> > > > >
> https://github.com/quarkiverse/quarkus-shardingsphere-jdbc/issues/84
> > > > > > > [4]
> > > > > >
> > >
> https://shardingsphere.apache.org/document/current/en/overview/#roadmap
> > > > > >
> > > > >
> > >
>
Re: [DISCUSS] Plan to drop support for JDK 8
Posted by Sheng Wu <wu...@gmail.com>.
Zheng Feng <zh...@gmail.com> 于2023年1月13日周五 21:04写道：
>
> I'm not pushing to drop JDK 8 now but I wonder if it is possible to
> maintain two LTS versions of shardingsphere. e.g. 5.x for JDK 8 and 6.x for
> JDK 11 above.
New features end, from my understanding, this is the end of support of JDK8.
Maintaining mode is only about high-priority bug fixing, and no
enhancement, no new feature, no performance improvement.
With time, many things can't cherry-pick back to the JDK 8.
>
> Sheng Wu <wu...@gmail.com> 于2023年1月13日周五 20:58写道：
>
> > From my side, only if there are key improvements for JDK 11, we are
> > worth taking that risk. Especially, whether these things are JDK 11
> > compiling only.
> > SkyWalking chose to use ShardingSphere proxy, but we discussed the
> > possibilities of ShardingJDBC, but if we made that choice(JDBC lib),
> > this change would totally make SkyWalking no choice but to stay in the
> > old release or remove this feature.
> >
> > This will be many of our end users' position if we announce that.
> >
> > JDK 8 actually has a longer LTS than JDK 11. JDK 8 - At least Nov
> > 2026, JDK 11 - At least Oct 2024
> > Source from Temurin(was, OpenJDK) https://adoptium.net/support/
> >
> > It will surprise everyone, ShardingSphere community removed the
> > primary and widely used JDK version, and move on to another
> > dead-earlier version :(
> >
> > If this is a vote for the future, I would say -1.
> >
> >
> > Sheng Wu 吴晟
> > Twitter, wusheng1108
> >
> > Zheng Feng <zh...@gmail.com> 于2023年1月13日周五 16:54写道：
> > >
> > > Yeah, I understand your concern for supporting the legacy applications
> > > especially for such users who have been using it in the production
> > > environment. But from the point of innovation, I think it would be great
> > to
> > > use the latest JDK which has many new impressive features. And sooner or
> > > later, we still have to face the problem of dropping JDK 8. So why don't
> > we
> > > consider it for now?
> > >
> > > I don't think 200+ modules is a BIG problem for maintaining work. You can
> > > see Apache camel which has 500+ modules but still supports 3 LTS
> > versions.
> > >
> > > There could be some way to help us to do backporting work such as using a
> > > github bot.
> > >
> > > Anway, I also think it would be an opportunity to think about the RoadMap
> > > of shardingsphere.
> > >
> > > Thanks,
> > > Zheng Feng
> > >
> > > zhangliang@apache.org <zh...@apache.org> 于2023年1月13日周五 14:42写道：
> > >
> > > > There are lots of legacy applications still using Java 8.
> > > > ShardingSphere-JDBC is a java lib, not standalone process, the LTS of
> > Java
> > > > 8 is necessary.
> > > >
> > > > But there are 200+ modules in ShardingSphere, so I am afraid nobody
> > > > can undertake the costs of maintain 2 different versions.
> > > >
> > > > ------------------
> > > >
> > > > Sincerely,
> > > > Liang Zhang (John)
> > > > Apache ShardingSphere
> > > >
> > > >
> > > > 吴伟杰 <wu...@apache.org> 于2023年1月12日周四 10:57写道：
> > > >
> > > > > I also want to use the Java 11 or 17.
> > > > > We have had to do some special handling in codes to avoid performance
> > > > > issues in Java 8 (such as JDK-8161372 [1]).
> > > > >
> > > > > [1] https://bugs.openjdk.java.net/browse/JDK-8161372
> > > > >
> > > > > Regards,
> > > > > Weijie
> > > > > -----------------------------------------------
> > > > >
> > > > > Wu Weijie 吴伟杰
> > > > > Apache ShardingSphere PMC
> > > > > GitHub@TeslaCN
> > > > >
> > > > > Zheng Feng <zh...@apache.org> 于2023年1月11日周三 20:18写道：
> > > > >
> > > > > >
> > > > > > Hi all,
> > > > > >
> > > > > > This thought is coming from upgrading antlr to 4.10.1 [1] which is
> > only
> > > > > for
> > > > > > Java 11 now. Currently it looks like that the Hibernate 6.0.x [2]
> > and
> > > > > > Quarkus 2.15.x [3] integrations has been blocked by this upgrading
> > > > issue.
> > > > > >
> > > > > > I think it could be some other 3rd party libraries with this
> > similar
> > > > > issue
> > > > > > sooner or later. So it is time to think about the plan to drop JDK
> > 8 in
> > > > > > shardingsphere now.
> > > > > >
> > > > > > I know this is BIG breaking change that could impact a lot of
> > people
> > > > who
> > > > > > use the shardingsphere. Also it is not very clear in current
> > roadmap
> > > > [4]
> > > > > > and the document for support JDKs.
> > > > > >
> > > > > > So my plan is to keep 5.x branch which sticks to JDK 8 and should
> > be a
> > > > > LTS
> > > > > > version (I'm not sure how long we will be like to support it?).
> > Then
> > > > bump
> > > > > > the master branch to 6.0 to drop JDK 8 support as soon as possible.
> > > > There
> > > > > > will be a little bit much more maintenance works with 5.x and
> > master
> > > > > > branches.
> > > > > >
> > > > > > What the others think? and we definitely need a formal voting
> > process
> > > > for
> > > > > > this plan after this discussion.
> > > > > >
> > > > > > Regards,
> > > > > > Zheng Feng
> > > > > >
> > > > > > [1] https://github.com/antlr/antlr4/releases/tag/4.10.1
> > > > > > [2] https://github.com/apache/shardingsphere/pull/20119
> > > > > > [3]
> > > > https://github.com/quarkiverse/quarkus-shardingsphere-jdbc/issues/84
> > > > > > [4]
> > > > >
> > https://shardingsphere.apache.org/document/current/en/overview/#roadmap
> > > > >
> > > >
> >
Re: [DISCUSS] Plan to drop support for JDK 8
Posted by Zheng Feng <zh...@gmail.com>.
I'm not pushing to drop JDK 8 now but I wonder if it is possible to
maintain two LTS versions of shardingsphere. e.g. 5.x for JDK 8 and 6.x for
JDK 11 above.
Sheng Wu <wu...@gmail.com> 于2023年1月13日周五 20:58写道：
> From my side, only if there are key improvements for JDK 11, we are
> worth taking that risk. Especially, whether these things are JDK 11
> compiling only.
> SkyWalking chose to use ShardingSphere proxy, but we discussed the
> possibilities of ShardingJDBC, but if we made that choice(JDBC lib),
> this change would totally make SkyWalking no choice but to stay in the
> old release or remove this feature.
>
> This will be many of our end users' position if we announce that.
>
> JDK 8 actually has a longer LTS than JDK 11. JDK 8 - At least Nov
> 2026, JDK 11 - At least Oct 2024
> Source from Temurin(was, OpenJDK) https://adoptium.net/support/
>
> It will surprise everyone, ShardingSphere community removed the
> primary and widely used JDK version, and move on to another
> dead-earlier version :(
>
> If this is a vote for the future, I would say -1.
>
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
> Zheng Feng <zh...@gmail.com> 于2023年1月13日周五 16:54写道：
> >
> > Yeah, I understand your concern for supporting the legacy applications
> > especially for such users who have been using it in the production
> > environment. But from the point of innovation, I think it would be great
> to
> > use the latest JDK which has many new impressive features. And sooner or
> > later, we still have to face the problem of dropping JDK 8. So why don't
> we
> > consider it for now?
> >
> > I don't think 200+ modules is a BIG problem for maintaining work. You can
> > see Apache camel which has 500+ modules but still supports 3 LTS
> versions.
> >
> > There could be some way to help us to do backporting work such as using a
> > github bot.
> >
> > Anway, I also think it would be an opportunity to think about the RoadMap
> > of shardingsphere.
> >
> > Thanks,
> > Zheng Feng
> >
> > zhangliang@apache.org <zh...@apache.org> 于2023年1月13日周五 14:42写道：
> >
> > > There are lots of legacy applications still using Java 8.
> > > ShardingSphere-JDBC is a java lib, not standalone process, the LTS of
> Java
> > > 8 is necessary.
> > >
> > > But there are 200+ modules in ShardingSphere, so I am afraid nobody
> > > can undertake the costs of maintain 2 different versions.
> > >
> > > ------------------
> > >
> > > Sincerely,
> > > Liang Zhang (John)
> > > Apache ShardingSphere
> > >
> > >
> > > 吴伟杰 <wu...@apache.org> 于2023年1月12日周四 10:57写道：
> > >
> > > > I also want to use the Java 11 or 17.
> > > > We have had to do some special handling in codes to avoid performance
> > > > issues in Java 8 (such as JDK-8161372 [1]).
> > > >
> > > > [1] https://bugs.openjdk.java.net/browse/JDK-8161372
> > > >
> > > > Regards,
> > > > Weijie
> > > > -----------------------------------------------
> > > >
> > > > Wu Weijie 吴伟杰
> > > > Apache ShardingSphere PMC
> > > > GitHub@TeslaCN
> > > >
> > > > Zheng Feng <zh...@apache.org> 于2023年1月11日周三 20:18写道：
> > > >
> > > > >
> > > > > Hi all,
> > > > >
> > > > > This thought is coming from upgrading antlr to 4.10.1 [1] which is
> only
> > > > for
> > > > > Java 11 now. Currently it looks like that the Hibernate 6.0.x [2]
> and
> > > > > Quarkus 2.15.x [3] integrations has been blocked by this upgrading
> > > issue.
> > > > >
> > > > > I think it could be some other 3rd party libraries with this
> similar
> > > > issue
> > > > > sooner or later. So it is time to think about the plan to drop JDK
> 8 in
> > > > > shardingsphere now.
> > > > >
> > > > > I know this is BIG breaking change that could impact a lot of
> people
> > > who
> > > > > use the shardingsphere. Also it is not very clear in current
> roadmap
> > > [4]
> > > > > and the document for support JDKs.
> > > > >
> > > > > So my plan is to keep 5.x branch which sticks to JDK 8 and should
> be a
> > > > LTS
> > > > > version (I'm not sure how long we will be like to support it?).
> Then
> > > bump
> > > > > the master branch to 6.0 to drop JDK 8 support as soon as possible.
> > > There
> > > > > will be a little bit much more maintenance works with 5.x and
> master
> > > > > branches.
> > > > >
> > > > > What the others think? and we definitely need a formal voting
> process
> > > for
> > > > > this plan after this discussion.
> > > > >
> > > > > Regards,
> > > > > Zheng Feng
> > > > >
> > > > > [1] https://github.com/antlr/antlr4/releases/tag/4.10.1
> > > > > [2] https://github.com/apache/shardingsphere/pull/20119
> > > > > [3]
> > > https://github.com/quarkiverse/quarkus-shardingsphere-jdbc/issues/84
> > > > > [4]
> > > >
> https://shardingsphere.apache.org/document/current/en/overview/#roadmap
> > > >
> > >
>
Re: [DISCUSS] Plan to drop support for JDK 8
Posted by Sheng Wu <wu...@gmail.com>.
From my side, only if there are key improvements for JDK 11, we are
worth taking that risk. Especially, whether these things are JDK 11
compiling only.
SkyWalking chose to use ShardingSphere proxy, but we discussed the
possibilities of ShardingJDBC, but if we made that choice(JDBC lib),
this change would totally make SkyWalking no choice but to stay in the
old release or remove this feature.
This will be many of our end users' position if we announce that.
JDK 8 actually has a longer LTS than JDK 11. JDK 8 - At least Nov
2026, JDK 11 - At least Oct 2024
Source from Temurin(was, OpenJDK) https://adoptium.net/support/
It will surprise everyone, ShardingSphere community removed the
primary and widely used JDK version, and move on to another
dead-earlier version :(
If this is a vote for the future, I would say -1.
Sheng Wu 吴晟
Twitter, wusheng1108
Zheng Feng <zh...@gmail.com> 于2023年1月13日周五 16:54写道：
>
> Yeah, I understand your concern for supporting the legacy applications
> especially for such users who have been using it in the production
> environment. But from the point of innovation, I think it would be great to
> use the latest JDK which has many new impressive features. And sooner or
> later, we still have to face the problem of dropping JDK 8. So why don't we
> consider it for now?
>
> I don't think 200+ modules is a BIG problem for maintaining work. You can
> see Apache camel which has 500+ modules but still supports 3 LTS versions.
>
> There could be some way to help us to do backporting work such as using a
> github bot.
>
> Anway, I also think it would be an opportunity to think about the RoadMap
> of shardingsphere.
>
> Thanks,
> Zheng Feng
>
> zhangliang@apache.org <zh...@apache.org> 于2023年1月13日周五 14:42写道：
>
> > There are lots of legacy applications still using Java 8.
> > ShardingSphere-JDBC is a java lib, not standalone process, the LTS of Java
> > 8 is necessary.
> >
> > But there are 200+ modules in ShardingSphere, so I am afraid nobody
> > can undertake the costs of maintain 2 different versions.
> >
> > ------------------
> >
> > Sincerely,
> > Liang Zhang (John)
> > Apache ShardingSphere
> >
> >
> > 吴伟杰 <wu...@apache.org> 于2023年1月12日周四 10:57写道：
> >
> > > I also want to use the Java 11 or 17.
> > > We have had to do some special handling in codes to avoid performance
> > > issues in Java 8 (such as JDK-8161372 [1]).
> > >
> > > [1] https://bugs.openjdk.java.net/browse/JDK-8161372
> > >
> > > Regards,
> > > Weijie
> > > -----------------------------------------------
> > >
> > > Wu Weijie 吴伟杰
> > > Apache ShardingSphere PMC
> > > GitHub@TeslaCN
> > >
> > > Zheng Feng <zh...@apache.org> 于2023年1月11日周三 20:18写道：
> > >
> > > >
> > > > Hi all,
> > > >
> > > > This thought is coming from upgrading antlr to 4.10.1 [1] which is only
> > > for
> > > > Java 11 now. Currently it looks like that the Hibernate 6.0.x [2] and
> > > > Quarkus 2.15.x [3] integrations has been blocked by this upgrading
> > issue.
> > > >
> > > > I think it could be some other 3rd party libraries with this similar
> > > issue
> > > > sooner or later. So it is time to think about the plan to drop JDK 8 in
> > > > shardingsphere now.
> > > >
> > > > I know this is BIG breaking change that could impact a lot of people
> > who
> > > > use the shardingsphere. Also it is not very clear in current roadmap
> > [4]
> > > > and the document for support JDKs.
> > > >
> > > > So my plan is to keep 5.x branch which sticks to JDK 8 and should be a
> > > LTS
> > > > version (I'm not sure how long we will be like to support it?). Then
> > bump
> > > > the master branch to 6.0 to drop JDK 8 support as soon as possible.
> > There
> > > > will be a little bit much more maintenance works with 5.x and master
> > > > branches.
> > > >
> > > > What the others think? and we definitely need a formal voting process
> > for
> > > > this plan after this discussion.
> > > >
> > > > Regards,
> > > > Zheng Feng
> > > >
> > > > [1] https://github.com/antlr/antlr4/releases/tag/4.10.1
> > > > [2] https://github.com/apache/shardingsphere/pull/20119
> > > > [3]
> > https://github.com/quarkiverse/quarkus-shardingsphere-jdbc/issues/84
> > > > [4]
> > > https://shardingsphere.apache.org/document/current/en/overview/#roadmap
> > >
> >
Re: [DISCUSS] Plan to drop support for JDK 8
Posted by Zheng Feng <zh...@gmail.com>.
Yeah, I understand your concern for supporting the legacy applications
especially for such users who have been using it in the production
environment. But from the point of innovation, I think it would be great to
use the latest JDK which has many new impressive features. And sooner or
later, we still have to face the problem of dropping JDK 8. So why don't we
consider it for now?
I don't think 200+ modules is a BIG problem for maintaining work. You can
see Apache camel which has 500+ modules but still supports 3 LTS versions.
There could be some way to help us to do backporting work such as using a
github bot.
Anway, I also think it would be an opportunity to think about the RoadMap
of shardingsphere.
Thanks,
Zheng Feng
zhangliang@apache.org <zh...@apache.org> 于2023年1月13日周五 14:42写道：
> There are lots of legacy applications still using Java 8.
> ShardingSphere-JDBC is a java lib, not standalone process, the LTS of Java
> 8 is necessary.
>
> But there are 200+ modules in ShardingSphere, so I am afraid nobody
> can undertake the costs of maintain 2 different versions.
>
> ------------------
>
> Sincerely,
> Liang Zhang (John)
> Apache ShardingSphere
>
>
> 吴伟杰 <wu...@apache.org> 于2023年1月12日周四 10:57写道：
>
> > I also want to use the Java 11 or 17.
> > We have had to do some special handling in codes to avoid performance
> > issues in Java 8 (such as JDK-8161372 [1]).
> >
> > [1] https://bugs.openjdk.java.net/browse/JDK-8161372
> >
> > Regards,
> > Weijie
> > -----------------------------------------------
> >
> > Wu Weijie 吴伟杰
> > Apache ShardingSphere PMC
> > GitHub@TeslaCN
> >
> > Zheng Feng <zh...@apache.org> 于2023年1月11日周三 20:18写道：
> >
> > >
> > > Hi all,
> > >
> > > This thought is coming from upgrading antlr to 4.10.1 [1] which is only
> > for
> > > Java 11 now. Currently it looks like that the Hibernate 6.0.x [2] and
> > > Quarkus 2.15.x [3] integrations has been blocked by this upgrading
> issue.
> > >
> > > I think it could be some other 3rd party libraries with this similar
> > issue
> > > sooner or later. So it is time to think about the plan to drop JDK 8 in
> > > shardingsphere now.
> > >
> > > I know this is BIG breaking change that could impact a lot of people
> who
> > > use the shardingsphere. Also it is not very clear in current roadmap
> [4]
> > > and the document for support JDKs.
> > >
> > > So my plan is to keep 5.x branch which sticks to JDK 8 and should be a
> > LTS
> > > version (I'm not sure how long we will be like to support it?). Then
> bump
> > > the master branch to 6.0 to drop JDK 8 support as soon as possible.
> There
> > > will be a little bit much more maintenance works with 5.x and master
> > > branches.
> > >
> > > What the others think? and we definitely need a formal voting process
> for
> > > this plan after this discussion.
> > >
> > > Regards,
> > > Zheng Feng
> > >
> > > [1] https://github.com/antlr/antlr4/releases/tag/4.10.1
> > > [2] https://github.com/apache/shardingsphere/pull/20119
> > > [3]
> https://github.com/quarkiverse/quarkus-shardingsphere-jdbc/issues/84
> > > [4]
> > https://shardingsphere.apache.org/document/current/en/overview/#roadmap
> >
>
Re: [DISCUSS] Plan to drop support for JDK 8
Posted by "zhangliang@apache.org" <zh...@apache.org>.
There are lots of legacy applications still using Java 8.
ShardingSphere-JDBC is a java lib, not standalone process, the LTS of Java
8 is necessary.
But there are 200+ modules in ShardingSphere, so I am afraid nobody
can undertake the costs of maintain 2 different versions.
------------------
Sincerely,
Liang Zhang (John)
Apache ShardingSphere
吴伟杰 <wu...@apache.org> 于2023年1月12日周四 10:57写道：
> I also want to use the Java 11 or 17.
> We have had to do some special handling in codes to avoid performance
> issues in Java 8 (such as JDK-8161372 [1]).
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8161372
>
> Regards,
> Weijie
> -----------------------------------------------
>
> Wu Weijie 吴伟杰
> Apache ShardingSphere PMC
> GitHub@TeslaCN
>
> Zheng Feng <zh...@apache.org> 于2023年1月11日周三 20:18写道：
>
> >
> > Hi all,
> >
> > This thought is coming from upgrading antlr to 4.10.1 [1] which is only
> for
> > Java 11 now. Currently it looks like that the Hibernate 6.0.x [2] and
> > Quarkus 2.15.x [3] integrations has been blocked by this upgrading issue.
> >
> > I think it could be some other 3rd party libraries with this similar
> issue
> > sooner or later. So it is time to think about the plan to drop JDK 8 in
> > shardingsphere now.
> >
> > I know this is BIG breaking change that could impact a lot of people who
> > use the shardingsphere. Also it is not very clear in current roadmap [4]
> > and the document for support JDKs.
> >
> > So my plan is to keep 5.x branch which sticks to JDK 8 and should be a
> LTS
> > version (I'm not sure how long we will be like to support it?). Then bump
> > the master branch to 6.0 to drop JDK 8 support as soon as possible. There
> > will be a little bit much more maintenance works with 5.x and master
> > branches.
> >
> > What the others think? and we definitely need a formal voting process for
> > this plan after this discussion.
> >
> > Regards,
> > Zheng Feng
> >
> > [1] https://github.com/antlr/antlr4/releases/tag/4.10.1
> > [2] https://github.com/apache/shardingsphere/pull/20119
> > [3] https://github.com/quarkiverse/quarkus-shardingsphere-jdbc/issues/84
> > [4]
> https://shardingsphere.apache.org/document/current/en/overview/#roadmap
>
Re: [DISCUSS] Plan to drop support for JDK 8
Posted by 吴伟杰 <wu...@apache.org>.
I also want to use the Java 11 or 17.
We have had to do some special handling in codes to avoid performance
issues in Java 8 (such as JDK-8161372 [1]).
[1] https://bugs.openjdk.java.net/browse/JDK-8161372
Regards,
Weijie
-----------------------------------------------
Wu Weijie 吴伟杰
Apache ShardingSphere PMC
GitHub@TeslaCN
Zheng Feng <zh...@apache.org> 于2023年1月11日周三 20:18写道：
>
> Hi all,
>
> This thought is coming from upgrading antlr to 4.10.1 [1] which is only for
> Java 11 now. Currently it looks like that the Hibernate 6.0.x [2] and
> Quarkus 2.15.x [3] integrations has been blocked by this upgrading issue.
>
> I think it could be some other 3rd party libraries with this similar issue
> sooner or later. So it is time to think about the plan to drop JDK 8 in
> shardingsphere now.
>
> I know this is BIG breaking change that could impact a lot of people who
> use the shardingsphere. Also it is not very clear in current roadmap [4]
> and the document for support JDKs.
>
> So my plan is to keep 5.x branch which sticks to JDK 8 and should be a LTS
> version (I'm not sure how long we will be like to support it?). Then bump
> the master branch to 6.0 to drop JDK 8 support as soon as possible. There
> will be a little bit much more maintenance works with 5.x and master
> branches.
>
> What the others think? and we definitely need a formal voting process for
> this plan after this discussion.
>
> Regards,
> Zheng Feng
>
> [1] https://github.com/antlr/antlr4/releases/tag/4.10.1
> [2] https://github.com/apache/shardingsphere/pull/20119
> [3] https://github.com/quarkiverse/quarkus-shardingsphere-jdbc/issues/84
> [4] https://shardingsphere.apache.org/document/current/en/overview/#roadmap