You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by scosenza <gi...@git.apache.org> on 2016/05/08 23:57:33 UTC
[GitHub] flink pull request: Build a flink-connector-kafka-0.9 test-jar
GitHub user scosenza opened a pull request:
https://github.com/apache/flink/pull/1972
Build a flink-connector-kafka-0.9 test-jar
Build a test-jar of flink-connector-kafka-0.9 so that Flink users can use KafkaTestEnvironmentImpl to write end to end integration tests of their Flink jobs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scosenza/flink patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1972.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1972
----
commit 2f6f25ae7aa3ff4ffc8c874ead9b769dee0b2b69
Author: Steve Cosenza <co...@gmail.com>
Date: 2016-05-08T23:55:06Z
Build a flink-connector-kafka-0.9 test-jar
Build a test-jar including KafkaTestEnvironmentImpl so that Flink users can write end to end integration tests of their Flink jobs.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Build a flink-connector-kafka-0.9 test-jar
Posted by scosenza <gi...@git.apache.org>.
Github user scosenza commented on the pull request:
https://github.com/apache/flink/pull/1972#issuecomment-218318387
Hi Robert,
Typically, a test-jar would not contain JUnit test classes unless they are designed to be extended. On a related note, it's also good to avoid including logback-test.xml inside your test-jars, as this leads to the following warning when others (who are also using logback) depend on your test-jar.
```
16:01:09,771 |-INFO in ch.qos.logback.classic.LoggerContext[default] - Found resource [logback-test.xml] at [file:/Users/.../target/test-classes/logback-test.xml]
16:01:09,772 |-WARN in ch.qos.logback.classic.LoggerContext[default] - Resource [logback-test.xml] occurs multiple times on the classpath.
16:01:09,772 |-WARN in ch.qos.logback.classic.LoggerContext[default] - Resource [logback-test.xml] occurs at [jar:file:/Users/scosenza/.m2/repository/org/apache/flink/flink-connector-kafka-base_2.11/1.0.2/flink-connector-kafka-base_2.11-1.0.2-tests.jar!/logback-test.xml]
16:01:09,772 |-WARN in ch.qos.logback.classic.LoggerContext[default] - Resource [logback-test.xml] occurs at [jar:file:/Users/scosenza/.m2/repository/org/apache/flink/flink-core/1.0.2/flink-core-1.0.2-tests.jar!/logback-test.xml]
16:01:09,772 |-WARN in ch.qos.logback.classic.LoggerContext[default] - Resource [logback-test.xml] occurs at [file:/Users/scosenza/.../target/test-classes/logback-test.xml]
16:01:09,772 |-WARN in ch.qos.logback.classic.LoggerContext[default] - Resource [logback-test.xml] occurs at [jar:file:/Users/scosenza/.m2/repository/org/apache/flink/flink-runtime_2.11/1.0.2/flink-runtime_2.11-1.0.2-tests.jar!/logback-test.xml]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Build a flink-connector-kafka-0.9 test-jar
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1972#issuecomment-219817117
I think this is good, will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Build a flink-connector-kafka-0.9 test-jar
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1972
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Build a flink-connector-kafka-0.9 test-jar
Posted by scosenza <gi...@git.apache.org>.
Github user scosenza commented on the pull request:
https://github.com/apache/flink/pull/1972#issuecomment-217753936
/cc @jgrier
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Build a flink-connector-kafka-0.9 test-jar
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1972#issuecomment-218087373
Hi,
thank you for opening a pull request about this. I think the change is good to merge. One thing I'm wondering is: why do you only include on class (or a set of classes with a shared prefix) into the test-jar?
I would put all test classes into the test-jar (we never know what users will need in the future)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---