You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "quinnj (via GitHub)" <gi...@apache.org> on 2023/06/08 14:01:40 UTC
[GitHub] [arrow-julia] quinnj opened a new pull request, #459: Fix case of recursively nested lists
quinnj opened a new pull request, #459:
URL: https://github.com/apache/arrow-julia/pull/459
Fixes issue reported by @Moelf in #458.
The issue is we need to get the eltype from the recursively built child array instead of as a top-level translation of the current field type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] Moelf commented on pull request #459: Fix case of recursively nested lists
Posted by "Moelf (via GitHub)" <gi...@apache.org>.
Moelf commented on PR #459:
URL: https://github.com/apache/arrow-julia/pull/459#issuecomment-1582639212
what happened to coverage :laughing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] quinnj commented on pull request #459: Fix case of recursively nested lists
Posted by "quinnj (via GitHub)" <gi...@apache.org>.
quinnj commented on PR #459:
URL: https://github.com/apache/arrow-julia/pull/459#issuecomment-1582657272
> what happened to coverage 😆
I think it's getting confused w/ ArrowTypes.jl CI jobs finishing first and then we're getting 0 coverage on _Arrow.jl_ files from ArrowTypes tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] quinnj merged pull request #459: Fix case of recursively nested lists
Posted by "quinnj (via GitHub)" <gi...@apache.org>.
quinnj merged PR #459:
URL: https://github.com/apache/arrow-julia/pull/459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] codecov-commenter commented on pull request #459: Fix case of recursively nested lists
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #459:
URL: https://github.com/apache/arrow-julia/pull/459#issuecomment-1582638082
## [Codecov](https://app.codecov.io/gh/apache/arrow-julia/pull/459?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#459](https://app.codecov.io/gh/apache/arrow-julia/pull/459?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a988fb9) into [main](https://app.codecov.io/gh/apache/arrow-julia/commit/f039a5e929e0a6d253788e4cf78b5e956841772f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f039a5e) will **decrease** coverage by `82.62%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #459 +/- ##
==========================================
- Coverage 87.55% 4.94% -82.62%
==========================================
Files 26 25 -1
Lines 3271 3194 -77
==========================================
- Hits 2864 158 -2706
- Misses 407 3036 +2629
```
| [Impacted Files](https://app.codecov.io/gh/apache/arrow-julia/pull/459?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [src/table.jl](https://app.codecov.io/gh/apache/arrow-julia/pull/459?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL3RhYmxlLmps) | `0.00% <0.00%> (-92.50%)` | :arrow_down: |
... and [23 files with indirect coverage changes](https://app.codecov.io/gh/apache/arrow-julia/pull/459/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] Moelf commented on pull request #459: Fix case of recursively nested lists
Posted by "Moelf (via GitHub)" <gi...@apache.org>.
Moelf commented on PR #459:
URL: https://github.com/apache/arrow-julia/pull/459#issuecomment-1582634939
thx for the swift fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org