You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by David Kantor <dk...@us.ibm.com> on 2016/04/30 02:04:50 UTC
Re: Review Request 46444: ATLAS-659: Fix issues with using embedded
HBase on Windows
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46444/
-----------------------------------------------------------
(Updated April 30, 2016, 12:04 a.m.)
Review request for atlas.
Changes
-------
Addressed Neeru's comment
Bugs: ATLAS-659
https://issues.apache.org/jira/browse/ATLAS-659
Repository: atlas
Description
-------
ATLAS-659: Fix issues with using embedded HBase on Windows so that HBase successfully starts and stops as part of Atlas startup/shutdown.
- Use correct HBase start and stop scripts for Windows
- Start HBase server after checking existing Atlas server
- Use Windows-specific template for hbase-site.xml - file URL for hbase.rootdir needs three slashes to avoid error: "Illegal character in authority at index 5"
- In TestMetadata.py, check mock for HBase Windows startup script
Diffs (updated)
-----
distro/src/bin/atlas_config.py 2b6bc825858cc5b36d55cba5b85b2087e8b4ecfe
distro/src/bin/atlas_start.py 4199e372c1357e490171fb1c9328c7529dbe0492
distro/src/bin/atlas_stop.py 5653244cff141b9e9fd68cf6877c4d6ec952ee0f
distro/src/conf/hbase/windows-hbase-site.xml.template PRE-CREATION
distro/src/test/python/scripts/TestMetadata.py bb74f2004501473fc726fe58e8f9ad1ead3e18f1
Diff: https://reviews.apache.org/r/46444/diff/
Testing
-------
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
Re: Review Request 46444: ATLAS-659: Fix issues with using embedded
HBase on Windows
Posted by David Kantor <dk...@us.ibm.com>.
> On May 4, 2016, 7:01 a.m., Shwetha GS wrote:
> > distro/src/conf/hbase/windows-hbase-site.xml.template, line 22
> > <https://reviews.apache.org/r/46444/diff/3/?file=1367785#file1367785line22>
> >
> > Can you use system property and avoid using different config files for windows and non-windows
Thanks very much for this comment, good idea. I have changed the implementation to use a property rather than having a separate windows config template.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46444/#review131634
-----------------------------------------------------------
On May 4, 2016, 4:04 p.m., David Kantor wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46444/
> -----------------------------------------------------------
>
> (Updated May 4, 2016, 4:04 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-659
> https://issues.apache.org/jira/browse/ATLAS-659
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-659: Fix issues with using embedded HBase on Windows so that HBase successfully starts and stops as part of Atlas startup/shutdown.
> - Use correct HBase start and stop scripts for Windows
> - Start HBase server after checking existing Atlas server
> - Use Windows-specific template for hbase-site.xml - file URL for hbase.rootdir needs three slashes to avoid error: "Illegal character in authority at index 5"
> - In TestMetadata.py, check mock for HBase Windows startup script
>
>
> Diffs
> -----
>
> distro/src/bin/atlas_config.py 2b6bc825858cc5b36d55cba5b85b2087e8b4ecfe
> distro/src/bin/atlas_start.py 4199e372c1357e490171fb1c9328c7529dbe0492
> distro/src/bin/atlas_stop.py 5653244cff141b9e9fd68cf6877c4d6ec952ee0f
> distro/src/conf/hbase/hbase-site.xml.template 4ace2fdf1a79b92c3c93d46e7c6f218ccd877151
> distro/src/test/python/scripts/TestMetadata.py bb74f2004501473fc726fe58e8f9ad1ead3e18f1
>
> Diff: https://reviews.apache.org/r/46444/diff/
>
>
> Testing
> -------
>
> Ran all unit and integration tests with no regressions.
>
>
> Thanks,
>
> David Kantor
>
>
Re: Review Request 46444: ATLAS-659: Fix issues with using embedded
HBase on Windows
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46444/#review131634
-----------------------------------------------------------
distro/src/conf/hbase/windows-hbase-site.xml.template (line 22)
<https://reviews.apache.org/r/46444/#comment195655>
Can you use system property and avoid using different config files for windows and non-windows
- Shwetha GS
On April 30, 2016, 12:04 a.m., David Kantor wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46444/
> -----------------------------------------------------------
>
> (Updated April 30, 2016, 12:04 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-659
> https://issues.apache.org/jira/browse/ATLAS-659
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-659: Fix issues with using embedded HBase on Windows so that HBase successfully starts and stops as part of Atlas startup/shutdown.
> - Use correct HBase start and stop scripts for Windows
> - Start HBase server after checking existing Atlas server
> - Use Windows-specific template for hbase-site.xml - file URL for hbase.rootdir needs three slashes to avoid error: "Illegal character in authority at index 5"
> - In TestMetadata.py, check mock for HBase Windows startup script
>
>
> Diffs
> -----
>
> distro/src/bin/atlas_config.py 2b6bc825858cc5b36d55cba5b85b2087e8b4ecfe
> distro/src/bin/atlas_start.py 4199e372c1357e490171fb1c9328c7529dbe0492
> distro/src/bin/atlas_stop.py 5653244cff141b9e9fd68cf6877c4d6ec952ee0f
> distro/src/conf/hbase/windows-hbase-site.xml.template PRE-CREATION
> distro/src/test/python/scripts/TestMetadata.py bb74f2004501473fc726fe58e8f9ad1ead3e18f1
>
> Diff: https://reviews.apache.org/r/46444/diff/
>
>
> Testing
> -------
>
> Ran all unit and integration tests with no regressions.
>
>
> Thanks,
>
> David Kantor
>
>
Re: Review Request 46444: ATLAS-659: Fix issues with using embedded
HBase on Windows
Posted by David Kantor <dk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46444/
-----------------------------------------------------------
(Updated May 9, 2016, 2:13 p.m.)
Review request for atlas.
Changes
-------
Updated description to reflect final changes.
Bugs: ATLAS-659
https://issues.apache.org/jira/browse/ATLAS-659
Repository: atlas
Description (updated)
-------
ATLAS-659: Fix issues with using embedded HBase on Windows so that HBase successfully starts and stops as part of Atlas startup/shutdown.
- Use correct HBase start and stop scripts for Windows
- Start HBase server after checking existing Atlas server
- In hbase-site.xml.template, use property for file URL prefix on hbase.rootdir, and set property with three slashes on Windows to avoid error: "Illegal character in authority at index 5"
- In TestMetadata.py, check mock for HBase Windows startup script
Diffs
-----
distro/src/bin/atlas_config.py 2b6bc825858cc5b36d55cba5b85b2087e8b4ecfe
distro/src/bin/atlas_start.py 4199e372c1357e490171fb1c9328c7529dbe0492
distro/src/bin/atlas_stop.py 5653244cff141b9e9fd68cf6877c4d6ec952ee0f
distro/src/conf/hbase/hbase-site.xml.template 4ace2fdf1a79b92c3c93d46e7c6f218ccd877151
distro/src/test/python/scripts/TestMetadata.py bb74f2004501473fc726fe58e8f9ad1ead3e18f1
Diff: https://reviews.apache.org/r/46444/diff/
Testing
-------
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
Re: Review Request 46444: ATLAS-659: Fix issues with using embedded
HBase on Windows
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46444/#review131809
-----------------------------------------------------------
Ship it!
Ship It!
- Shwetha GS
On May 4, 2016, 4:04 p.m., David Kantor wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46444/
> -----------------------------------------------------------
>
> (Updated May 4, 2016, 4:04 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-659
> https://issues.apache.org/jira/browse/ATLAS-659
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-659: Fix issues with using embedded HBase on Windows so that HBase successfully starts and stops as part of Atlas startup/shutdown.
> - Use correct HBase start and stop scripts for Windows
> - Start HBase server after checking existing Atlas server
> - Use Windows-specific template for hbase-site.xml - file URL for hbase.rootdir needs three slashes to avoid error: "Illegal character in authority at index 5"
> - In TestMetadata.py, check mock for HBase Windows startup script
>
>
> Diffs
> -----
>
> distro/src/bin/atlas_config.py 2b6bc825858cc5b36d55cba5b85b2087e8b4ecfe
> distro/src/bin/atlas_start.py 4199e372c1357e490171fb1c9328c7529dbe0492
> distro/src/bin/atlas_stop.py 5653244cff141b9e9fd68cf6877c4d6ec952ee0f
> distro/src/conf/hbase/hbase-site.xml.template 4ace2fdf1a79b92c3c93d46e7c6f218ccd877151
> distro/src/test/python/scripts/TestMetadata.py bb74f2004501473fc726fe58e8f9ad1ead3e18f1
>
> Diff: https://reviews.apache.org/r/46444/diff/
>
>
> Testing
> -------
>
> Ran all unit and integration tests with no regressions.
>
>
> Thanks,
>
> David Kantor
>
>
Re: Review Request 46444: ATLAS-659: Fix issues with using embedded
HBase on Windows
Posted by David Kantor <dk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46444/
-----------------------------------------------------------
(Updated May 4, 2016, 4:04 p.m.)
Review request for atlas.
Changes
-------
Addressed Shwetha's comment - now uses a property for the URL prefix rather than having a separate template file for Windows.
Bugs: ATLAS-659
https://issues.apache.org/jira/browse/ATLAS-659
Repository: atlas
Description
-------
ATLAS-659: Fix issues with using embedded HBase on Windows so that HBase successfully starts and stops as part of Atlas startup/shutdown.
- Use correct HBase start and stop scripts for Windows
- Start HBase server after checking existing Atlas server
- Use Windows-specific template for hbase-site.xml - file URL for hbase.rootdir needs three slashes to avoid error: "Illegal character in authority at index 5"
- In TestMetadata.py, check mock for HBase Windows startup script
Diffs (updated)
-----
distro/src/bin/atlas_config.py 2b6bc825858cc5b36d55cba5b85b2087e8b4ecfe
distro/src/bin/atlas_start.py 4199e372c1357e490171fb1c9328c7529dbe0492
distro/src/bin/atlas_stop.py 5653244cff141b9e9fd68cf6877c4d6ec952ee0f
distro/src/conf/hbase/hbase-site.xml.template 4ace2fdf1a79b92c3c93d46e7c6f218ccd877151
distro/src/test/python/scripts/TestMetadata.py bb74f2004501473fc726fe58e8f9ad1ead3e18f1
Diff: https://reviews.apache.org/r/46444/diff/
Testing
-------
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor