[GitHub] [incubator-seatunnel] ruanwenjun opened a new issue #1473: [Improvement][Config] Print config in origin order

[GitBox <gi...@apache.org>]

ruanwenjun opened a new issue #1473:
URL: https://github.com/apache/incubator-seatunnel/issues/1473


   ### Search before asking
   
   - [X] I had searched in the [feature](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22) and found no similar feature requirement.
   
   
   ### Description
   
   When I execute a job in seatunnel, it will print config in log, this is helpful, but it will change the order of element in config.
   For example, config is look like below:
   ```
   env {
     execution.parallelism = 1
   }
   source {
       FakeSourceStream {
         result_table_name = "fake"
         field_name = "name,age"
       }
   }
   transform {
       sql {
         sql = "select name,age from fake"
       }
   }
   sink {
     ConsoleSink {}
   }
   ```
   The print message will be: 
   ```
   env {
     execution.parallelism = 1
   }
   sink {
     ConsoleSink {}
   }
   source {
       FakeSourceStream {
         result_table_name = "fake"
         field_name = "name,age"
       }
   }
   transform {
       sql {
         sql = "select name,age from fake"
       }
   }
   ```
   This sometimes make me confused. I find this is caused by when `SimpleConfigObject` execute render method, it will sort the key. See `SimpleConfigObject#render(StringBuilder sb, int indent, boolean atRoot, ConfigRenderOptions options)`
   ```
   Arrays.sort(keys, new SimpleConfigObject.RenderComparator());
   ```
   
   I want to rewrite this method, this need to copy `SimpleConfigObject` into `seatunnel-config-shade` module.
   
   After test, this can work.
   
   I want to ask if it's necessary to do this, I don't know if other guys think like me.
   
   
   ### Usage Scenario
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs closed issue #1473: [Improvement][Config] Print config in origin order

[GitBox <gi...@apache.org>]

CalvinKirs closed issue #1473:
URL: https://github.com/apache/incubator-seatunnel/issues/1473


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org