You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ivan Veselovsky (JIRA)" <ji...@apache.org> on 2017/04/28 16:48:04 UTC
[jira] [Comment Edited] (IGNITE-1925) Test
HadoopSkipListSelfTest.testLevel flakily fails
[ https://issues.apache.org/jira/browse/IGNITE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989130#comment-15989130 ]
Ivan Veselovsky edited comment on IGNITE-1925 at 4/28/17 4:47 PM:
------------------------------------------------------------------
[~vozerov] , the fix is that org.apache.ignite.internal.processors.hadoop.shuffle.collections.HadoopSkipList#randomLevel returns value in range 0..Infinity, not 0..32 or 0..64. This makes the function correct. The point is that the returned value should not be limited . With very low probability it may return any positive number. And comprehensive statistic analysis performed in the test really reveals that: if you use old #randomLevel function (now it is called "randomLevel32"), the test will start to fail with noticeable probability.
was (Author: iveselovskiy):
[~vozerov] , the fix is that org.apache.ignite.internal.processors.hadoop.shuffle.collections.HadoopSkipList#randomLevel returns value in range 0..Infinity, not 0..32 or 0..64. This makes the function correct. The point is that the returned value should not be limited . With very low probability it may return any positive number. And comprehensive statistic analysis performed in the test really reveals that: if you use old #randomLevel function (now it is called "renndomLevel32"), the test will start to fail with noticeable probability.
> Test HadoopSkipListSelfTest.testLevel flakily fails
> ---------------------------------------------------
>
> Key: IGNITE-1925
> URL: https://issues.apache.org/jira/browse/IGNITE-1925
> Project: Ignite
> Issue Type: Bug
> Components: hadoop
> Affects Versions: 1.6
> Reporter: Ivan Veselovsky
> Assignee: Ivan Veselovsky
> Priority: Minor
>
> Test HadoopSkipListSelfTest.testLevel fails from time to time with ~ 3% probability.
>
> junit.framework.AssertionFailedError: null
> at junit.framework.Assert.fail(Assert.java:55)
> at junit.framework.Assert.assertTrue(Assert.java:22)
> at junit.framework.Assert.assertTrue(Assert.java:31)
> at junit.framework.TestCase.assertTrue(TestCase.java:201)
> at org.apache.ignite.internal.processors.hadoop.shuffle.collections.HadoopSkipListSelfTest.testLevel(HadoopSkipListSelfTest.java:83)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)