You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/11/09 14:15:57 UTC
[GitHub] [avro] zcsizmadia opened a new pull request #1394: AVRO-3250: Support .NET 6.0
zcsizmadia opened a new pull request #1394:
URL: https://github.com/apache/avro/pull/1394
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO-3250) issues
- https://issues.apache.org/jira/browse/AVRO-3250
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1394: AVRO-3250: Support .NET 6.0
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1394:
URL: https://github.com/apache/avro/pull/1394#issuecomment-964213331
Added the .NET SDK dependencies to the github actions. (suggested by https://blog.elmah.io/building-and-testing-on-multiple-net-versions-with-github-actions/). This seems more solid, to explicitly installing it, so we dont depend on SDKS included in the latest github ubuntu image. (Which I thought was a bare image anyway)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1394: AVRO-3250: Support .NET 6.0
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1394:
URL: https://github.com/apache/avro/pull/1394#issuecomment-964462327
https://github.com/actions/virtual-environments/issues/4424#issuecomment-962938487
This suggests, that it is probably a good idea to install the .NET SDKs explicitly and relying on the base image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] ostsmolynets commented on pull request #1394: AVRO-3250: Support .NET 6.0
Posted by GitBox <gi...@apache.org>.
ostsmolynets commented on pull request #1394:
URL: https://github.com/apache/avro/pull/1394#issuecomment-987140572
Hi, we are moving our projects to .net 6 and depend on Avro.Tools in some of them.
It's great to see you guys already working on the support for the new version.
Would be really nice to know if the support is coming any time soon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g merged pull request #1394: AVRO-3250: Support .NET 6.0
Posted by GitBox <gi...@apache.org>.
martin-g merged pull request #1394:
URL: https://github.com/apache/avro/pull/1394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1394: AVRO-3250: Support .NET 6.0
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1394:
URL: https://github.com/apache/avro/pull/1394#issuecomment-964215984
No, it is not a bare image.
See the table at https://github.com/actions/virtual-environments/#available-environments.
At the moment it is build 20211108.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1394: AVRO-3250: Support .NET 6.0
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1394:
URL: https://github.com/apache/avro/pull/1394#issuecomment-1023018708
There are some new C# PRs which we have to review and merge.
I guess we could start a new release later next week.
On Thu, Jan 27, 2022, 00:19 Zoltan Csizmadia ***@***.***>
wrote:
> @martin-g <https://github.com/martin-g> Do you have an estimate when
> 1.11.1 would be released? We are using avrogen and would like to move to
> net6, but avrogen is holding us back.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/avro/pull/1394#issuecomment-1022655990>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABYUQSHAXCU3E5JBIVIXF3UYBXQBANCNFSM5HVM5U6Q>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1394: AVRO-3250: Support .NET 6.0
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1394:
URL: https://github.com/apache/avro/pull/1394#issuecomment-964197897
It seems GitHub Actions does not yet provide v6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1394: AVRO-3250: Support .NET 6.0
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1394:
URL: https://github.com/apache/avro/pull/1394#issuecomment-1008803500
Thank you for the contribution, @zcsizmadia !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1394: AVRO-3250: Support .NET 6.0
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1394:
URL: https://github.com/apache/avro/pull/1394#issuecomment-1022655990
@martin-g Do you have an estimate when 1.11.1 would be released? We are using avrogen and would like to move to net6, but avrogen is holding us back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1394: AVRO-3250: Support .NET 6.0
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1394:
URL: https://github.com/apache/avro/pull/1394#issuecomment-964198917
I am not sure how the gitflow test will use the latest dotnet 6.0. I dont see any reference to specify to install any of the dotnet sdks into the gitflow. I am not sure what I am missing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia edited a comment on pull request #1394: AVRO-3250: Support .NET 6.0
Posted by GitBox <gi...@apache.org>.
zcsizmadia edited a comment on pull request #1394:
URL: https://github.com/apache/avro/pull/1394#issuecomment-964462327
https://github.com/actions/virtual-environments/issues/4424#issuecomment-962938487
This suggests, that it is probably a good idea to install the .NET SDKs explicitly and not relying on the base image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1394: AVRO-3250: Support .NET 6.0
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1394:
URL: https://github.com/apache/avro/pull/1394#issuecomment-964206496
Either this or wait few days until GHA people add it to their images. I guess .NET is popular at GitHub :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1394: AVRO-3250: Support .NET 6.0
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1394:
URL: https://github.com/apache/avro/pull/1394#issuecomment-964201157
Maybe we should have setup-dotnet added to the dotnet gitflow tests (https://github.com/actions/setup-dotnet)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org