You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/10/02 13:23:17 UTC
[GitHub] [flink] TisonKun commented on issue #9682: [FLINK-14041][tests]
Refactor LeaderRetrievalServiceHostnameResolutionTest and remove
StandaloneUtils
TisonKun commented on issue #9682: [FLINK-14041][tests] Refactor LeaderRetrievalServiceHostnameResolutionTest and remove StandaloneUtils
URL: https://github.com/apache/flink/pull/9682#issuecomment-537489792
Thanks for your review @zentol ! I can see your concern here.
Actually the original tests test `AkkaRpcServicesUtils#getRpcUrl` and since that `StandaloneUtils` is never used outside these tests it seems we tests nothing about abstract leader retrieval service. In fact, the retrieval of WebMonitor is a bit different from `AkkaRpcServicesUtils#getRpcUrl`(said it is `HighAvailabilityServicesUtils#getWebMonitorAddress`). I think we can even guard by `AkkaUtilsTest` and maybe add a dedicate test for `HighAvailabilityServicesUtils#getWebMonitorAddress` and delete `LeaderRetrievalServiceHostnameResolutionTest` because it doesn't test something at that abstraction level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services