You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/15 18:27:44 UTC
[kudu-CR] [clock] more info on refusal to advance hybrid timestamp
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14455
Change subject: [clock] more info on refusal to advance hybrid timestamp
......................................................................
[clock] more info on refusal to advance hybrid timestamp
Enhanced the error message on the attempt to update hybrid timestamp
beyond the maximum allowed error threshold.
This patch does not contain any functional changes.
Change-Id: I676fc89fb96fa5383ae354207b64bed3ffe00300
---
M src/kudu/clock/hybrid_clock.cc
1 file changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/14455/1
--
To view, visit http://gerrit.cloudera.org:8080/14455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I676fc89fb96fa5383ae354207b64bed3ffe00300
Gerrit-Change-Number: 14455
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [clock] more info on refusal to advance hybrid timestamp
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14455 )
Change subject: [clock] more info on refusal to advance hybrid timestamp
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14455/1/src/kudu/clock/hybrid_clock.cc
File src/kudu/clock/hybrid_clock.cc:
http://gerrit.cloudera.org:8080/#/c/14455/1/src/kudu/clock/hybrid_clock.cc@288
PS1, Line 288: to_udpate
> to_update
Done
--
To view, visit http://gerrit.cloudera.org:8080/14455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676fc89fb96fa5383ae354207b64bed3ffe00300
Gerrit-Change-Number: 14455
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Oct 2019 00:07:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] [clock] more info on refusal to advance hybrid timestamp
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14455 )
Change subject: [clock] more info on refusal to advance hybrid timestamp
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14455/1/src/kudu/clock/hybrid_clock.cc
File src/kudu/clock/hybrid_clock.cc:
http://gerrit.cloudera.org:8080/#/c/14455/1/src/kudu/clock/hybrid_clock.cc@288
PS1, Line 288: to_udpate
to_update
--
To view, visit http://gerrit.cloudera.org:8080/14455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676fc89fb96fa5383ae354207b64bed3ffe00300
Gerrit-Change-Number: 14455
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Oct 2019 20:06:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] [clock] more info on refusal to advance hybrid timestamp
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14455 )
Change subject: [clock] more info on refusal to advance hybrid timestamp
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676fc89fb96fa5383ae354207b64bed3ffe00300
Gerrit-Change-Number: 14455
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Oct 2019 00:40:33 +0000
Gerrit-HasComments: No
[kudu-CR] [clock] more info on refusal to advance hybrid timestamp
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14455
to look at the new patch set (#2).
Change subject: [clock] more info on refusal to advance hybrid timestamp
......................................................................
[clock] more info on refusal to advance hybrid timestamp
Enhanced the error message on the attempt to update hybrid timestamp
beyond the maximum allowed error threshold.
This patch does not contain any functional changes.
Change-Id: I676fc89fb96fa5383ae354207b64bed3ffe00300
---
M src/kudu/clock/hybrid_clock.cc
1 file changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/14455/2
--
To view, visit http://gerrit.cloudera.org:8080/14455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I676fc89fb96fa5383ae354207b64bed3ffe00300
Gerrit-Change-Number: 14455
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [clock] more info on refusal to advance hybrid timestamp
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14455 )
Change subject: [clock] more info on refusal to advance hybrid timestamp
......................................................................
[clock] more info on refusal to advance hybrid timestamp
Enhanced the error message on the attempt to update hybrid timestamp
beyond the maximum allowed error threshold.
This patch does not contain any functional changes.
Change-Id: I676fc89fb96fa5383ae354207b64bed3ffe00300
Reviewed-on: http://gerrit.cloudera.org:8080/14455
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/clock/hybrid_clock.cc
1 file changed, 11 insertions(+), 7 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I676fc89fb96fa5383ae354207b64bed3ffe00300
Gerrit-Change-Number: 14455
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)