You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/08 20:32:21 UTC
[GitHub] [incubator-superset] graceguo-supercat opened a new pull request
#8014: [fix] Allow dashboard viewer auto refresh dashboard
graceguo-supercat opened a new pull request #8014: [fix] Allow dashboard viewer auto refresh dashboard
URL: https://github.com/apache/incubator-superset/pull/8014
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [x] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
before #7248, dashboard viewers and owners can auto refresh dashboard periodically, but this refresh frequency can not be saved into dashboard metadata. In #7248, dashboard owner can change refresh frequency and save it as part of dashboard metadata, so that next time viewer open dashboard, it will auto-refresh per owner's setting. But in this PR, viewers lost their options to change refresh frequency, even they doesn't want to change owner's setting. There are some cases where dashboard owner didn't set auto refresh, but viewers still want to auto refresh during current visit.
This PR added back this feature:
- dashboard viewers can trigger auto refresh for this visit, but this change won't persist.
- In edit mode, if dashboard owner changes auto refresh frequency, this change will be saved into dashboard metadata.
### AFTER SCREENSHOTS OR ANIMATED GIF
Dashboard viewers will see menu `Auto-refresh dashboard`:
<img width="251" alt="Screen Shot 2019-08-08 at 12 49 59 PM" src="https://user-images.githubusercontent.com/27990562/62735735-b01cc880-b9e0-11e9-9d40-05ee0fabac6a.png">
Dashboard owners will see `Set auto-refresh interval`:
<img width="502" alt="Screen Shot 2019-08-08 at 12 50 17 PM" src="https://user-images.githubusercontent.com/27990562/62735751-bd39b780-b9e0-11e9-9cc7-df0bb4042bec.png">
### TEST PLAN
CI, and manual test.
### REVIEWERS
@betodealmeida @michellethomas @mistercrunch @etr2460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org