You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/07/12 11:02:24 UTC
[GitHub] [spark] LuciferYang commented on pull request #40611: [SPARK-42981][CONNECT] Add direct arrow serialization
LuciferYang commented on PR #40611:
URL: https://github.com/apache/spark/pull/40611#issuecomment-1632295248
@hvanhovell checked with Scala 2.13
```
dev/change-scala-version.sh 2.13
build/sbt clean "connect-client-jvm/testOnly org.apache.spark.sql.connect.client.arrow.ArrowEncoderSuite" -Pscala-2.13
```
There are 2 TESTS FAILED in my local:
```
[info] - javabean *** FAILED *** (31 milliseconds)
[info] org.apache.spark.sql.catalyst.DummyBean@67edd08e did not equal org.apache.spark.sql.catalyst.DummyBean@4bf9bb36 (ArrowEncoderSuite.scala:192)
[info] org.scalatest.exceptions.TestFailedException:
[info] at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
[info] at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
[info] at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
[info] at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
[info] at org.apache.spark.sql.connect.client.arrow.ArrowEncoderSuite.$anonfun$compareIterators$1(ArrowEncoderSuite.scala:192)
[info] at scala.collection.IterableOnceOps.foreach(IterableOnce.scala:576)
[info] at scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:574)
[info] at scala.collection.AbstractIterator.foreach(Iterator.scala:1300)
[info] at org.apache.spark.sql.connect.client.arrow.ArrowEncoderSuite.compareIterators(ArrowEncoderSuite.scala:189)
[info] at org.apache.spark.sql.connect.client.arrow.ArrowEncoderSuite.roundTripAndCheck(ArrowEncoderSuite.scala:153)
[info] at org.apache.spark.sql.connect.client.arrow.ArrowEncoderSuite.roundTripAndCheckIdentical(ArrowEncoderSuite.scala:172)
[info] at org.apache.spark.sql.connect.client.arrow.ArrowEncoderSuite.$anonfun$new$26(ArrowEncoderSuite.scala:385)
...
[info] - java maps *** FAILED *** (36 milliseconds)
[info] org.apache.spark.sql.connect.client.arrow.JavaMapData@10b8bd8b did not equal org.apache.spark.sql.connect.client.arrow.JavaMapData@7de88d79 (ArrowEncoderSuite.scala:192)
[info] org.scalatest.exceptions.TestFailedException:
[info] at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
[info] at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
[info] at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
[info] at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
[info] at org.apache.spark.sql.connect.client.arrow.ArrowEncoderSuite.$anonfun$compareIterators$1(ArrowEncoderSuite.scala:192)
[info] at scala.collection.IterableOnceOps.foreach(IterableOnce.scala:576)
[info] at scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:574)
[info] at scala.collection.AbstractIterator.foreach(Iterator.scala:1300)
[info] at org.apache.spark.sql.connect.client.arrow.ArrowEncoderSuite.compareIterators(ArrowEncoderSuite.scala:189)
[info] at org.apache.spark.sql.connect.client.arrow.ArrowEncoderSuite.roundTripAndCheck(ArrowEncoderSuite.scala:153)
[info] at org.apache.spark.sql.connect.client.arrow.ArrowEncoderSuite.roundTripAndCheckIdentical(ArrowEncoderSuite.scala:172)
[info] at org.apache.spark.sql.connect.client.arrow.ArrowEncoderSuite.$anonfun$new$63(ArrowEncoderSuite.scala:522)
[info] at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
[info] at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
```
I'm not sure if this is a issue with my local environment ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org