You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Zhijie Shen (JIRA)" <ji...@apache.org> on 2013/08/02 09:25:49 UTC
[jira] [Updated] (YARN-953) [YARN-321] Change ResourceManager to
use HistoryStorage to log history data
[ https://issues.apache.org/jira/browse/YARN-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhijie Shen updated YARN-953:
-----------------------------
Attachment: YARN-953.2.patch
Thanks Vinod! The new patch addresses the comments.
bq. Instead of adding a new DummyApplicationHistoryWriter, we can just use the InMemoryStorage that is being worked on the other JIRA. The default should be InMemoryStorage. Can you work on top of YARN-956?
Still keep DummyApplicationHistoryWriter for the case of disabling the the writing history service.
bq. Instead of individual setters, you should create newInstance methods in ApplicationHistoryData, ApplicationAttemptHistoryData and ContainerHistoryData.
Added newInstance for these three classes.
bq. Also the HistoryEvents can and should create and send the data objects instead of sending all of RMApp, RMAppAttempt etc.
HistoryEvents are changed to take the history data as the parameters.
bq. In the test, instead of calling writeApplication etc, you should affect a state transition by using MockRM APIs. See TestRM for example.
TestRMApplicationHistoryWriter focuses on the correctness of RMApplicationHistoryWriter's APIs. Therefore, I kept it unchanged. However, I added more code in TestRMAppTransition, TestRMAppAttemptTransition and TestRMContainerImpl to check whether the writing API is called when the object transits to its final state.
> [YARN-321] Change ResourceManager to use HistoryStorage to log history data
> ---------------------------------------------------------------------------
>
> Key: YARN-953
> URL: https://issues.apache.org/jira/browse/YARN-953
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Zhijie Shen
> Attachments: YARN-953.1.patch, YARN-953.2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira