You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2015/10/20 08:22:27 UTC
[GitHub] tajo pull request: TAJO-1653: Add 'INSERT INTO VALUES' statement f...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/832
TAJO-1653: Add 'INSERT INTO VALUES' statement for OLTP-like storages.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1653
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/832.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #832
----
commit 49484fecbb959f1c94814a8dd040f49c673fbef2
Author: Hyunsik Choi <hy...@apache.org>
Date: 2015-10-20T06:20:56Z
TAJO-1653: Add 'INSERT INTO VALUES' statement for OLTP-like storages.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1653: Add 'INSERT INTO VALUES' statement f...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/832#discussion_r42833830
--- Diff: tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLParser.g4 ---
@@ -951,7 +951,7 @@ parenthesized_boolean_value_expression
/*
===============================================================================
- 7.2 <row value expression>
+ 7.2 <row value expression> (p293)
--- End diff --
Would you explain what ```p293``` means?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1653: Add 'INSERT INTO VALUES' statement f...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/832#issuecomment-150465595
Hi @hyunsik, this patch emits the following error.
```
pgsql_db> insert into test values (1::int8, 'name1');
ERROR: org.apache.tajo.exception.NotImplementedException: not implemented feature: org.apache.tajo.storage.jdbc.JdbcTablespace::verifySchemaToWrite
```
Here is the log.
```
2015-10-23 13:19:03,298 WARN org.apache.tajo.plan.verifier.VerificationState: org.apache.tajo.master.GlobalEngine:verifyInsertTableSchema(320) causes: org.apache.tajo.exception.NotImplementedException: not implemented feature: org.apache.tajo.storage.jdbc.JdbcTablespace::verifySchemaToWrite
2015-10-23 13:19:03,298 ERROR org.apache.tajo.master.GlobalEngine:
Stack Trace:
org.apache.tajo.exception.TajoRuntimeException: org.apache.tajo.exception.NotImplementedException: not implemented feature: org.apache.tajo.storage.jdbc.JdbcTablespace::verifySchemaToWrite
at org.apache.tajo.storage.jdbc.JdbcTablespace.verifySchemaToWrite(JdbcTablespace.java:160)
at org.apache.tajo.master.GlobalEngine.verifyInsertTableSchema(GlobalEngine.java:315)
at org.apache.tajo.master.GlobalEngine.createLogicalPlan(GlobalEngine.java:287)
at org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:190)
at org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:303)
at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:675)
at org.apache.tajo.rpc.BlockingRpcServer$ServerHandler.channelRead0(BlockingRpcServer.java:100)
at org.apache.tajo.rpc.BlockingRpcServer$ServerHandler.channelRead0(BlockingRpcServer.java:61)
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308)
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294)
at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308)
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294)
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:244)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308)
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294)
at io.netty.channel.ChannelInboundHandlerAdapter.channelRead(ChannelInboundHandlerAdapter.java:86)
at org.apache.tajo.rpc.MonitorServerHandler.channelRead(MonitorServerHandler.java:70)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308)
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294)
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:846)
at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131)
at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:511)
at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:468)
at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:382)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:354)
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:111)
at java.lang.Thread.run(Thread.java:745)
Caused by: org.apache.tajo.exception.NotImplementedException: not implemented feature: org.apache.tajo.storage.jdbc.JdbcTablespace::verifySchemaToWrite
... 29 more
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1653: Add 'INSERT INTO VALUES' statement f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/832
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1653: Add 'INSERT INTO VALUES' statement f...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/832#issuecomment-150484687
Thank you! I just committed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1653: Add 'INSERT INTO VALUES' statement f...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/832#issuecomment-150475431
Oh, ok. I misunderstood due to the title.
Here is my +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1653: Add 'INSERT INTO VALUES' statement f...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/832#issuecomment-150468989
This issue is for Tajo QueryExecutor layer. So, it works with Hbase that already supports INSERT. In contrast, JDBC storage does not support INSERT.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---