You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2018/05/28 19:06:26 UTC
Review Request 67346: ATLAS-2723: search performance improvement:
create
composite index for __traitNames with typeName and superTypeNames
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67346/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Sarath Subramanian.
Bugs: ATLAS-2723
https://issues.apache.org/jira/browse/ATLAS-2723
Repository: atlas
Description
-------
Search performance improvement with the following updates:
- created composite index for __traitNames property with typeName and superTypeNames
- better end-of-results detection, to avoid an additional query
Diffs
-----
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java d63e1d774
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java b5e75fefb
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 0ef32563f
repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java dbbb435fe
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 4faa7ba54
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java e148aa741
Diff: https://reviews.apache.org/r/67346/diff/1/
Testing
-------
- verified that the search returns right results, as before
- pre-commit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/458/
Thanks,
Madhan Neethiraj
Re: Review Request 67346: ATLAS-2723: search performance improvement:
create
composite index for __traitNames with typeName and superTypeNames
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67346/#review203984
-----------------------------------------------------------
Ship it!
Ship It!
- Ashutosh Mestry
On May 29, 2018, 6:53 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67346/
> -----------------------------------------------------------
>
> (Updated May 29, 2018, 6:53 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2723
> https://issues.apache.org/jira/browse/ATLAS-2723
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Search performance improvement with the following updates:
> - created composite index for __traitNames property with typeName and superTypeNames
> - better end-of-results detection, to avoid an additional query
>
>
> Diffs
> -----
>
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java d63e1d774
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java b5e75fefb
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 0ef32563f
> repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java dbbb435fe
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 4faa7ba54
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java e148aa741
>
>
> Diff: https://reviews.apache.org/r/67346/diff/2/
>
>
> Testing
> -------
>
> - verified that the search returns right results, as before
> - pre-commit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/458/
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 67346: ATLAS-2723: search performance improvement:
create
composite index for __traitNames with typeName and superTypeNames
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67346/
-----------------------------------------------------------
(Updated May 29, 2018, 6:53 a.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Sarath Subramanian.
Changes
-------
addressed review comments.
Bugs: ATLAS-2723
https://issues.apache.org/jira/browse/ATLAS-2723
Repository: atlas
Description
-------
Search performance improvement with the following updates:
- created composite index for __traitNames property with typeName and superTypeNames
- better end-of-results detection, to avoid an additional query
Diffs (updated)
-----
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java d63e1d774
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java b5e75fefb
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 0ef32563f
repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java dbbb435fe
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 4faa7ba54
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java e148aa741
Diff: https://reviews.apache.org/r/67346/diff/2/
Changes: https://reviews.apache.org/r/67346/diff/1-2/
Testing
-------
- verified that the search returns right results, as before
- pre-commit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/458/
Thanks,
Madhan Neethiraj
Re: Review Request 67346: ATLAS-2723: search performance improvement:
create
composite index for __traitNames with typeName and superTypeNames
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67346/#review203958
-----------------------------------------------------------
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java
Lines 219 (patched)
<https://reviews.apache.org/r/67346/#comment286323>
Can you add isDebug clause here, so that this does not get indavertently called.
- Ashutosh Mestry
On May 28, 2018, 7:06 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67346/
> -----------------------------------------------------------
>
> (Updated May 28, 2018, 7:06 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2723
> https://issues.apache.org/jira/browse/ATLAS-2723
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Search performance improvement with the following updates:
> - created composite index for __traitNames property with typeName and superTypeNames
> - better end-of-results detection, to avoid an additional query
>
>
> Diffs
> -----
>
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java d63e1d774
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java b5e75fefb
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 0ef32563f
> repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java dbbb435fe
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 4faa7ba54
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java e148aa741
>
>
> Diff: https://reviews.apache.org/r/67346/diff/1/
>
>
> Testing
> -------
>
> - verified that the search returns right results, as before
> - pre-commit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/458/
>
>
> Thanks,
>
> Madhan Neethiraj
>
>