You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/06/20 20:24:55 UTC
[GitHub] [camel-quarkus] lburgazzoli opened a new pull request #1391: Make camel-quarkus-rest depend on camel-quarkus-platform-http
lburgazzoli opened a new pull request #1391:
URL: https://github.com/apache/camel-quarkus/pull/1391
Fixes #1244
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on pull request #1391: Make camel-quarkus-rest depend on camel-quarkus-platform-http
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #1391:
URL: https://github.com/apache/camel-quarkus/pull/1391#issuecomment-647047114
Requires some more work on camel side
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli closed pull request #1391: Make camel-quarkus-rest depend on camel-quarkus-platform-http
Posted by GitBox <gi...@apache.org>.
lburgazzoli closed pull request #1391:
URL: https://github.com/apache/camel-quarkus/pull/1391
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1391: Make camel-quarkus-rest depend on camel-quarkus-platform-http
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1391:
URL: https://github.com/apache/camel-quarkus/pull/1391#discussion_r443397796
##########
File path: docs/modules/ROOT/pages/extensions/rest.adoc
##########
@@ -27,3 +27,8 @@ Please refer to the above links for usage and configuration details.
----
Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
+
+== Additional Camel Quarkus configuration
+
+By default this extension configures the xref:extensions/platform-http.adoc as the component that provides the REST transport.
Review comment:
"By default this extension configures" awakes the impression that the end user can change the default. I guess the user can change it by calling `context.getRestConfiguration().setComponent(...)` from his RoutesBuilder but there is no way to remove platform-http from the class path. I think it would be useful to inform the end user about that, e.g.:
---8<-----
You can override the default from your `RouteBuilder`:
```
import org.apache.camel.builder.RouteBuilder;
public class MyRouteBuilder extends RouteBuilder {
@Override
public void configure() throws Exception {
getContext().getRestConfiguration().setComponent(...);
}
}
```
Note that by changing the default, the `platform-http` extension is not removed from your application's class path.
---8<-----
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org