You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/26 10:39:01 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #6666: [AIRFLOW-6069] Python host version in travis is set to 3.6 always

potiuk commented on a change in pull request #6666: [AIRFLOW-6069] Python host version in travis is set to 3.6 always
URL: https://github.com/apache/airflow/pull/6666#discussion_r350662057
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -42,29 +41,25 @@ jobs:
     - name: "Build documentation"
       env: >-
         PYTHON_VERSION=3.6
-      python: "3.6"
       stage: pre-test
       script: ./scripts/ci/ci_docs.sh
     - name: "Tests postgres python 3.6"
       env: >-
         BACKEND=postgres
         ENV=docker
         PYTHON_VERSION=3.6
-      python: "3.6"
       stage: test
     - name: "Tests sqlite python 3.6"
       env:
         BACKEND=sqlite
         ENV=docker
         PYTHON_VERSION=3.6
-      python: "3.6"
       stage: test
     - name: "Tests mysql python 3.7"
       env:
         BACKEND=mysql
         ENV=docker
         PYTHON_VERSION=3.7
-      python: "3.7"
 
 Review comment:
   Exactly. This make a difference for example for static checks which do not use container (for example debug statements check). It's not relevant for the: code tests/mypy/pylint/flake (they are all using containers with PYTHON_VERSION. 
   
   BTW. See here for all the tests with "Breeze" * -> those all use PYTHON_VERSION and containers:  https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#supported-pre-commit-hooks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services