You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org> on 2012/07/23 08:34:33 UTC
[jira] [Created] (BOOKKEEPER-349) Entry logger should close all the
chennels which are there in Map, instead of closing only current channel.
Uma Maheswara Rao G created BOOKKEEPER-349:
----------------------------------------------
Summary: Entry logger should close all the chennels which are there in Map, instead of closing only current channel.
Key: BOOKKEEPER-349
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-349
Project: Bookkeeper
Issue Type: Bug
Components: bookkeeper-server
Affects Versions: 4.1.0
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G
I have seen this on restarting the same bookies from same JVM( in one of mey testcase which I was writing for autoRecovery work), i.e, all channels are not getting closed.
When we restart the same bookie, there are 0.log channel will be a older channel. Since the current code cares about only current logChannel. So, we are not releasing the older channels on EntryLogger shutdown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-349) Entry logger should close all
the chennels which are there in Map, instead of closing only current
channel.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422019#comment-13422019 ]
Sijie Guo commented on BOOKKEEPER-349:
--------------------------------------
although I don't have windows environment to run it to verify it, the changes are necessary and right to me. +1.
> Entry logger should close all the chennels which are there in Map, instead of closing only current channel.
> -----------------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-349
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-349
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: BOOKKEEPER-349.patch
>
>
> I have seen this on restarting the same bookies from same JVM( in one of mey testcase which I was writing for autoRecovery work), i.e, all channels are not getting closed.
> When we restart the same bookie, there are 0.log channel will be a older channel. Since the current code cares about only current logChannel. So, we are not releasing the older channels on EntryLogger shutdown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-349) Entry logger should close all the
chennels which are there in Map, instead of closing only current channel.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated BOOKKEEPER-349:
-------------------------------------------
Attachment: BOOKKEEPER-349.patch
Attached a simple patch.
I have ran all recovery tests in windows, with this patch all were passing. Without this patch, some tests were failing while cleaning resources of data dirs.
> Entry logger should close all the chennels which are there in Map, instead of closing only current channel.
> -----------------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-349
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-349
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: BOOKKEEPER-349.patch
>
>
> I have seen this on restarting the same bookies from same JVM( in one of mey testcase which I was writing for autoRecovery work), i.e, all channels are not getting closed.
> When we restart the same bookie, there are 0.log channel will be a older channel. Since the current code cares about only current logChannel. So, we are not releasing the older channels on EntryLogger shutdown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-349) Entry logger should close all
the chennels which are there in Map, instead of closing only current
channel.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423029#comment-13423029 ]
Hudson commented on BOOKKEEPER-349:
-----------------------------------
Integrated in bookkeeper-trunk #620 (See [https://builds.apache.org/job/bookkeeper-trunk/620/])
BOOKKEEPER-349: Entry logger should close all the chennels which are there in Map, instead of closing only current channel. (umamaheswararao via sijie) (Revision 1365869)
Result = UNSTABLE
sijie :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
> Entry logger should close all the chennels which are there in Map, instead of closing only current channel.
> -----------------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-349
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-349
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-349.patch
>
>
> I have seen this on restarting the same bookies from same JVM( in one of mey testcase which I was writing for autoRecovery work), i.e, all channels are not getting closed.
> When we restart the same bookie, there are 0.log channel will be a older channel. Since the current code cares about only current logChannel. So, we are not releasing the older channels on EntryLogger shutdown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-349) Entry logger should close all
the chennels which are there in Map, instead of closing only current
channel.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422128#comment-13422128 ]
Sijie Guo commented on BOOKKEEPER-349:
--------------------------------------
@Uma, I would remove unused imports when committing, thanks for reminder.
> Entry logger should close all the chennels which are there in Map, instead of closing only current channel.
> -----------------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-349
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-349
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: BOOKKEEPER-349.patch
>
>
> I have seen this on restarting the same bookies from same JVM( in one of mey testcase which I was writing for autoRecovery work), i.e, all channels are not getting closed.
> When we restart the same bookie, there are 0.log channel will be a older channel. Since the current code cares about only current logChannel. So, we are not releasing the older channels on EntryLogger shutdown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-349) Entry logger should close all
the chennels which are there in Map, instead of closing only current
channel.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422099#comment-13422099 ]
Uma Maheswara Rao G commented on BOOKKEEPER-349:
------------------------------------------------
Thanks a lot Sijie, for reviewing the patch.
I noticed there is on unused import.
Do you mind removing it while committing?
-Thanks
Uma
> Entry logger should close all the chennels which are there in Map, instead of closing only current channel.
> -----------------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-349
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-349
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: BOOKKEEPER-349.patch
>
>
> I have seen this on restarting the same bookies from same JVM( in one of mey testcase which I was writing for autoRecovery work), i.e, all channels are not getting closed.
> When we restart the same bookie, there are 0.log channel will be a older channel. Since the current code cares about only current logChannel. So, we are not releasing the older channels on EntryLogger shutdown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira