You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/07/16 08:22:36 UTC

[GitHub] [commons-collections] marcwrobel opened a new pull request, #323: (chore) Fix minor typos

marcwrobel opened a new pull request, #323:
URL: https://github.com/apache/commons-collections/pull/323

   Fix various minor typos in :
   
   - project documentations,
   - javadoc and comments,
   - method attribute and variable names,
   - test method names.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] garydgregory commented on pull request #323: (chore) Fix minor typos

Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #323:
URL: https://github.com/apache/commons-collections/pull/323#issuecomment-1283890565

   That might be worse, it's just the same to review but spread out ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] garydgregory commented on pull request #323: (chore) Fix minor typos

Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #323:
URL: https://github.com/apache/commons-collections/pull/323#issuecomment-1282974146

   > @garydgregory ?
   
   100+ files changed puts this on the todo list for the weekend most likely...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] garydgregory commented on pull request #323: (chore) Fix minor typos

Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #323:
URL: https://github.com/apache/commons-collections/pull/323#issuecomment-1284639342

   Hi @marcwrobel 
   Please revert changes to the `bloomfilter` package, I don't make to make work for #335 
   TY


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] codecov-commenter commented on pull request #323: (chore) Fix minor typos

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #323:
URL: https://github.com/apache/commons-collections/pull/323#issuecomment-1186125219

   # [Codecov](https://codecov.io/gh/apache/commons-collections/pull/323?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#323](https://codecov.io/gh/apache/commons-collections/pull/323?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bcc2185) into [master](https://codecov.io/gh/apache/commons-collections/commit/ef728ec96bde5cc7bd5f4c4947720fc972b742a1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ef728ec) will **decrease** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #323      +/-   ##
   ============================================
   - Coverage     86.05%   85.99%   -0.06%     
   + Complexity     4680     4678       -2     
   ============================================
     Files           287      287              
     Lines         13484    13484              
     Branches       1978     1978              
   ============================================
   - Hits          11603    11596       -7     
   - Misses         1321     1325       +4     
   - Partials        560      563       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/commons-collections/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...va/org/apache/commons/collections4/ArrayStack.java](https://codecov.io/gh/apache/commons-collections/pull/323/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L0FycmF5U3RhY2suamF2YQ==) | `76.66% <ø> (ø)` | |
   | [.../org/apache/commons/collections4/ClosureUtils.java](https://codecov.io/gh/apache/commons-collections/pull/323/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L0Nsb3N1cmVVdGlscy5qYXZh) | `100.00% <ø> (ø)` | |
   | [...g/apache/commons/collections4/ComparatorUtils.java](https://codecov.io/gh/apache/commons-collections/pull/323/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L0NvbXBhcmF0b3JVdGlscy5qYXZh) | `78.57% <ø> (ø)` | |
   | [...rg/apache/commons/collections4/FluentIterable.java](https://codecov.io/gh/apache/commons-collections/pull/323/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L0ZsdWVudEl0ZXJhYmxlLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...java/org/apache/commons/collections4/MapUtils.java](https://codecov.io/gh/apache/commons-collections/pull/323/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L01hcFV0aWxzLmphdmE=) | `93.30% <ø> (ø)` | |
   | [...java/org/apache/commons/collections4/SetUtils.java](https://codecov.io/gh/apache/commons-collections/pull/323/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L1NldFV0aWxzLmphdmE=) | `72.97% <ø> (ø)` | |
   | [...ache/commons/collections4/bag/SynchronizedBag.java](https://codecov.io/gh/apache/commons-collections/pull/323/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2JhZy9TeW5jaHJvbml6ZWRCYWcuamF2YQ==) | `91.66% <ø> (ø)` | |
   | [...ommons/collections4/bag/SynchronizedSortedBag.java](https://codecov.io/gh/apache/commons-collections/pull/323/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2JhZy9TeW5jaHJvbml6ZWRTb3J0ZWRCYWcuamF2YQ==) | `25.00% <ø> (ø)` | |
   | [...mons/collections4/bidimap/AbstractDualBidiMap.java](https://codecov.io/gh/apache/commons-collections/pull/323/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2JpZGltYXAvQWJzdHJhY3REdWFsQmlkaU1hcC5qYXZh) | `97.19% <ø> (ø)` | |
   | [...ache/commons/collections4/bidimap/TreeBidiMap.java](https://codecov.io/gh/apache/commons-collections/pull/323/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2JpZGltYXAvVHJlZUJpZGlNYXAuamF2YQ==) | `85.85% <ø> (ø)` | |
   | ... and [46 more](https://codecov.io/gh/apache/commons-collections/pull/323/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-collections/pull/323?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/commons-collections/pull/323?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ef728ec...bcc2185](https://codecov.io/gh/apache/commons-collections/pull/323?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] marcwrobel commented on pull request #323: (chore) Fix minor typos

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on PR #323:
URL: https://github.com/apache/commons-collections/pull/323#issuecomment-1230767099

   @garydgregory, I just resolved the conflicts. #320 has been merged so this PR is ready for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] marcwrobel commented on pull request #323: (chore) Fix minor typos

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on PR #323:
URL: https://github.com/apache/commons-collections/pull/323#issuecomment-1283924410

   I resolved a conflict and rolled back the changes in files that were also changed in #335 (only two typos were rolled back). The two PRs should not conflict with each other.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] garydgregory commented on pull request #323: (chore) Fix minor typos

Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #323:
URL: https://github.com/apache/commons-collections/pull/323#issuecomment-1199205121

   Holding off on this one until #320 is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] marcwrobel commented on pull request #323: (chore) Fix minor typos

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on PR #323:
URL: https://github.com/apache/commons-collections/pull/323#issuecomment-1285038365

   @garydgregory, all changes related to the bloomfilter package have been reverted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] marcwrobel commented on pull request #323: (chore) Fix minor typos

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on PR #323:
URL: https://github.com/apache/commons-collections/pull/323#issuecomment-1282373298

   @garydgregory ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] marcwrobel commented on pull request #323: (chore) Fix minor typos

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on PR #323:
URL: https://github.com/apache/commons-collections/pull/323#issuecomment-1271600547

   @garydgregory, conflicts resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] garydgregory merged pull request #323: Fix minor typos

Posted by GitBox <gi...@apache.org>.
garydgregory merged PR #323:
URL: https://github.com/apache/commons-collections/pull/323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] marcwrobel commented on pull request #323: (chore) Fix minor typos

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on PR #323:
URL: https://github.com/apache/commons-collections/pull/323#issuecomment-1283880403

   @garydgregory, will it help you if I split this PR into multiple smaller PRs ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org