You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/25 11:40:35 UTC

[GitHub] [spark] MaxGekk opened a new pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

MaxGekk opened a new pull request #30499:
URL: https://github.com/apache/spark/pull/30499


   ### What changes were proposed in this pull request?
   The purpose of this PR is to extract the common tests for v1 and v2 ALTER TABLE .. PARTITION, and run them for both DSv1 and DSv2.
   
   This PR follows the approach for `SHOW TABLES` and `SHOW PARTITIONS`:
   - https://github.com/apache/spark/pull/30287
   - https://github.com/apache/spark/pull/30377
   
   ### Why are the changes needed?
   1. To improve test coverage of v1 and v2 implementations of  `ALTER TABLE .. PARTITION` commands.
   2. To improve tests maintainability.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   By running new test suites:
   - `AlterTablePartitionParserSuite`
   - `v2/AlterTablePartitionSuite`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30499:
URL: https://github.com/apache/spark/pull/30499#issuecomment-733897173






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30499:
URL: https://github.com/apache/spark/pull/30499#issuecomment-733833289






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30499:
URL: https://github.com/apache/spark/pull/30499#issuecomment-733670353






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30499:
URL: https://github.com/apache/spark/pull/30499#issuecomment-733667386


   **[Test build #131773 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131773/testReport)** for PR 30499 at commit [`3abb93d`](https://github.com/apache/spark/commit/3abb93dcbf9f718862cdf114f633912261fbf687).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30499:
URL: https://github.com/apache/spark/pull/30499#issuecomment-733833289






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30499:
URL: https://github.com/apache/spark/pull/30499#issuecomment-733670353






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk closed pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #30499:
URL: https://github.com/apache/spark/pull/30499


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30499:
URL: https://github.com/apache/spark/pull/30499#issuecomment-733667386


   **[Test build #131773 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131773/testReport)** for PR 30499 at commit [`3abb93d`](https://github.com/apache/spark/commit/3abb93dcbf9f718862cdf114f633912261fbf687).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #30499:
URL: https://github.com/apache/spark/pull/30499#issuecomment-741738991


   Replaced by https://github.com/apache/spark/pull/30685


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30499:
URL: https://github.com/apache/spark/pull/30499#issuecomment-733736073


   **[Test build #131781 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131781/testReport)** for PR 30499 at commit [`665d7d8`](https://github.com/apache/spark/commit/665d7d84a15053cafb42cf2a65b3093c60d85f55).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30499:
URL: https://github.com/apache/spark/pull/30499#issuecomment-733882455


   **[Test build #131781 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131781/testReport)** for PR 30499 at commit [`665d7d8`](https://github.com/apache/spark/commit/665d7d84a15053cafb42cf2a65b3093c60d85f55).
    * This patch **fails SparkR unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30499:
URL: https://github.com/apache/spark/pull/30499#issuecomment-733736073


   **[Test build #131781 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131781/testReport)** for PR 30499 at commit [`665d7d8`](https://github.com/apache/spark/commit/665d7d84a15053cafb42cf2a65b3093c60d85f55).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30499:
URL: https://github.com/apache/spark/pull/30499#issuecomment-733670331


   **[Test build #131773 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131773/testReport)** for PR 30499 at commit [`3abb93d`](https://github.com/apache/spark/commit/3abb93dcbf9f718862cdf114f633912261fbf687).
    * This patch **fails to build**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org