You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Ollie Bennett (JIRA)" <ji...@apache.org> on 2015/09/15 17:47:47 UTC
[jira] [Commented] (CB-7980) Multi-APK building depending on
webview
[ https://issues.apache.org/jira/browse/CB-7980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745628#comment-14745628 ]
Ollie Bennett commented on CB-7980:
-----------------------------------
The fix for this issue causes problems when defining android-versionCode in config.xml.
The documentation (https://cordova.apache.org/docs/en/5.0.0/config_ref_index.md.html - see "Additional Versioning") suggests that the versionCode will use the default ONLY if I don't specify a versionCode:
versionCode = PATCH + MINOR * 100 + MAJOR * 10000
This patch makes the assumption that I have used the default versionCode, and appends (for example) an '8' to the versionCode.
https://github.com/apache/cordova-android/commit/7cfb33d0ef057ec5cbe23c30b4ac0c8dd504933c#diff-c37e154983ced1f8b9a9fa3754f78542R113
Given that I have not used the default versionCode generation, it is frustrating that an '8' is appended to my version code. My releases become '408' then '418' then '428' etc. which is quite non-sensical.
I'm not sure whether this is worth fixing, although it allows an unusual and unintuitive situation to arise.
Apologies if this is the wrong place to raise this. I'll can create a new issue elsewhere if appropriate.
> Multi-APK building depending on webview
> ---------------------------------------
>
> Key: CB-7980
> URL: https://issues.apache.org/jira/browse/CB-7980
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Android
> Reporter: Mark Koudritsky
> Assignee: Andrew Grieve
>
> Set versionCode depending on whether we are building multiple APKs and which minSdkVersion is set.
> versionCode = (major * 10,000 + minor * 100 + micro) * 10
> Then the last digit is set to
> 8: if minSdkVersion is 14+ (Minimum requirement for crosswalk)
> 9: if minSdkVersion is 20+ (Minimum requirement for auto-updated system webview)
> 0: crorss-platfrom but minSdkVersion < 20
> 2: arm 32
> 3: reserved for arm64
> 4: x86
> 5: reserved for x86-64
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org