You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Josh Elser (JIRA)" <ji...@apache.org> on 2016/01/05 18:50:39 UTC
[jira] [Updated] (PHOENIX-2563) Pherf's ResourceList should fail
gracefully if a Jar file doesn't exist
[ https://issues.apache.org/jira/browse/PHOENIX-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Josh Elser updated PHOENIX-2563:
--------------------------------
Attachment: PHOENIX-2563.patch
Patch modifies ResourceList to catch FileNotFoundException and return an empty list instead of throwing an Error. Added a simple unit test to verify this.
> Pherf's ResourceList should fail gracefully if a Jar file doesn't exist
> -----------------------------------------------------------------------
>
> Key: PHOENIX-2563
> URL: https://issues.apache.org/jira/browse/PHOENIX-2563
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Minor
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2563.patch
>
>
> {code}
> ZipFile zf;
> try {
> zf = new ZipFile(file);
> } catch (final ZipException e) {
> throw new Error(e);
> } catch (final IOException e) {
> throw new Error(e);
> }
> {code}
> I had a symlink in my {{$HBASE_HOME/lib}} to a jar file that didn't actually exist on the filesystem. This in itself is fine, but when pherf scanned through the classpath looking for the xml scenario/schema files, it failed because we couldn't open this file.
> It would be much nicer if this code returns an empty list instead of throwing an Error (also, why Error and not RuntimeException).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)