You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/17 11:35:34 UTC
[GitHub] [apisix] mongudu opened a new pull request #6361: docs: Add authentication flow diagram to openid-connect.md (#6360)
mongudu opened a new pull request #6361:
URL: https://github.com/apache/apisix/pull/6361
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #6361: docs: Add authentication flow diagram to openid-connect.md (#6360)
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #6361:
URL: https://github.com/apache/apisix/pull/6361#issuecomment-1046046301
I think the doc should be well-designed for humans to read, instead of adding patches of images or texts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] mongudu edited a comment on pull request #6361: docs: Add authentication flow diagram to openid-connect.md (#6360)
Posted by GitBox <gi...@apache.org>.
mongudu edited a comment on pull request #6361:
URL: https://github.com/apache/apisix/pull/6361#issuecomment-1044724944
No problem!
Maybe you are already aware of it but let me add a comment here;
I had attached the diagram's sources in a text file next to the image file. Anyone can use the sources and regenerate the image again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] mongudu commented on pull request #6361: docs: Add authentication flow diagram to openid-connect.md (#6360)
Posted by GitBox <gi...@apache.org>.
mongudu commented on pull request #6361:
URL: https://github.com/apache/apisix/pull/6361#issuecomment-1044724944
No problem!
Maybe you are already aware of it but let me add a comment here;
I had attached the diagram's sources in a text file format next to the image file. Anyone can use the sources and regenerate the image again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org