[GitHub] [superset] eschutho commented on a change in pull request #18629: chore: move data nav menu to plus menu

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #18629:
URL: https://github.com/apache/superset/pull/18629#discussion_r804124778



##########
File path: superset-frontend/src/views/components/Menu.test.tsx
##########
@@ -220,13 +258,11 @@ test('should render the dropdown items', async () => {
   render(<Menu {...notanonProps} />);
   const dropdown = screen.getByTestId('new-dropdown-icon');
   userEvent.hover(dropdown);
-  expect(await screen.findByText(dropdownItems[0].label)).toHaveAttribute(
+todo (philip): test data submenu

Review comment:
       should this be a comment?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org