You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "scholarsmate (via GitHub)" <gi...@apache.org> on 2023/04/04 14:20:55 UTC
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #559: Data Editor UI has togglable color mode.
scholarsmate commented on code in PR #559:
URL: https://github.com/apache/daffodil-vscode/pull/559#discussion_r1157333046
##########
src/svelte/src/components/dataEditor.svelte:
##########
@@ -774,658 +781,713 @@ limitations under the License.
scrollSearchResults(false)
}
break
+ case MessageCommand.setUITheme:
+ $darkUITheme = msg.data.theme === 2
+ break
}
})
</script>
<svelte:window on:keydown|nonpassive={handleKeybind} />
-<header>
- <div class="header-container">
- <fieldset class="box file-metrics">
- <legend>File Metrics</legend>
- <div class="flex-container row wrap">
- <div class="row-item flex-container col">
- <label for="file_name" class="col-item file-metrics">Path</label>
- <div id="file_name" class="col-item file-name">{$fileName}</div>
- </div>
- </div>
- <hr />
- <div class="flex-container row" style="padding-top: 5pt;">
- <div class="two-row-items flex-container col">
- <label class="col-item file-metrics" for="disk_file_size"
- >Disk Size</label
- >
- <div class="col-item" id="disk_file_size">{$diskFileSize}</div>
- </div>
- <div class="two-row-item flex-container col">
- <label class="col-item file-metrics" for="computed_file_size"
- >Computed Size</label
- >
- <div class="col-item" id="computed_file_size">
- {$computedFileSize}
+<body class={$UIThemeCSSClass}>
Review Comment:
Why use a `body` tag? This is going to be injected into VS Code markup which will already have a body.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org