You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <je...@gmail.com> on 2015/10/30 23:10:45 UTC

Review Request 39825: GEODE-520: GFSH Alter Region entry-time-to-live-expiration causes subsequent server restart to fail.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39825/
-----------------------------------------------------------

Review request for geode and Darrel Schneider.


Repository: geode


Description
-------

GEODE-520: GFSH Alter Region entry-time-to-live-expiration causes subsequent server restart to fail.


Diffs
-----

  gemfire-core/src/main/java/com/gemstone/gemfire/cache/AttributesFactory.java 6af21b1abc1b0084be7917af61c83a2c94b629f2 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegion.java ed5a39044bba1dff1736e109c4d16a2fa46a9c2e 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java ce50c5276c208a6a169cc390ea31993c3a0b1fd9 
  gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java f5b4ab28058352f131669a642884d0993a4a74d9 

Diff: https://reviews.apache.org/r/39825/diff/


Testing
-------

Ran the following DUnits which all extend RegionTestCase

DiskDistributedNoAckAsyncOverflowRegionDUnitTest
DiskDistributedNoAckAsyncRegionDUnitTest
DiskDistributedNoAckSyncOverflowRegionDUnitTest
DistributedAckOverflowRegionCCECompressionDUnitTest
DistributedAckOverflowRegionCCEDUnitTest
DistributedAckOverflowRegionCCEOffHeapDUnitTest
DistributedAckPersistentRegionCCECompressionDUnitTest
DistributedAckPersistentRegionCCEDUnitTest
DistributedAckPersistentRegionCCEOffHeapDUnitTest
DistributedAckRegionCCEDUnitTest
DistributedAckRegionCCEOffHeapDUnitTest
DistributedAckRegionCompressionDUnitTest
DistributedAckRegionDUnitTest
DistributedAckRegionOffHeapDUnitTest
DistributedNoAckRegionCCEDUnitTest
DistributedNoAckRegionCCEOffHeapDUnitTest
DistributedNoAckRegionCompressionDUnitTest
DistributedNoAckRegionDUnitTest
DistributedNoAckRegionOffHeapDUnitTest
GlobalRegionCCEDUnitTest
GlobalRegionCCEOffHeapDUnitTest
GlobalRegionCompressionDUnitTest
GlobalRegionDUnitTest
GlobalRegionOffHeapDUnitTest
LocalRegionDUnitTest
PartitionedRegionCompressionDUnitTest
PartitionedRegionDUnitTest
PartitionedRegionOffHeapDUnitTest


Thanks,

Jens Deppe


Re: Review Request 39825: GEODE-520: GFSH Alter Region entry-time-to-live-expiration causes subsequent server restart to fail.

Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39825/#review104811
-----------------------------------------------------------

Ship it!


Ship It!

- Darrel Schneider


On Oct. 30, 2015, 3:10 p.m., Jens Deppe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39825/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 3:10 p.m.)
> 
> 
> Review request for geode and Darrel Schneider.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-520: GFSH Alter Region entry-time-to-live-expiration causes subsequent server restart to fail.
> 
> 
> Diffs
> -----
> 
>   gemfire-core/src/main/java/com/gemstone/gemfire/cache/AttributesFactory.java 6af21b1abc1b0084be7917af61c83a2c94b629f2 
>   gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegion.java ed5a39044bba1dff1736e109c4d16a2fa46a9c2e 
>   gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java ce50c5276c208a6a169cc390ea31993c3a0b1fd9 
>   gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java f5b4ab28058352f131669a642884d0993a4a74d9 
> 
> Diff: https://reviews.apache.org/r/39825/diff/
> 
> 
> Testing
> -------
> 
> Ran the following DUnits which all extend RegionTestCase
> 
> DiskDistributedNoAckAsyncOverflowRegionDUnitTest
> DiskDistributedNoAckAsyncRegionDUnitTest
> DiskDistributedNoAckSyncOverflowRegionDUnitTest
> DistributedAckOverflowRegionCCECompressionDUnitTest
> DistributedAckOverflowRegionCCEDUnitTest
> DistributedAckOverflowRegionCCEOffHeapDUnitTest
> DistributedAckPersistentRegionCCECompressionDUnitTest
> DistributedAckPersistentRegionCCEDUnitTest
> DistributedAckPersistentRegionCCEOffHeapDUnitTest
> DistributedAckRegionCCEDUnitTest
> DistributedAckRegionCCEOffHeapDUnitTest
> DistributedAckRegionCompressionDUnitTest
> DistributedAckRegionDUnitTest
> DistributedAckRegionOffHeapDUnitTest
> DistributedNoAckRegionCCEDUnitTest
> DistributedNoAckRegionCCEOffHeapDUnitTest
> DistributedNoAckRegionCompressionDUnitTest
> DistributedNoAckRegionDUnitTest
> DistributedNoAckRegionOffHeapDUnitTest
> GlobalRegionCCEDUnitTest
> GlobalRegionCCEOffHeapDUnitTest
> GlobalRegionCompressionDUnitTest
> GlobalRegionDUnitTest
> GlobalRegionOffHeapDUnitTest
> LocalRegionDUnitTest
> PartitionedRegionCompressionDUnitTest
> PartitionedRegionDUnitTest
> PartitionedRegionOffHeapDUnitTest
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>