You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/06 18:08:31 UTC

[GitHub] [arrow] pitrou opened a new pull request #9912: ARROW-9451: [Python] Refuse implicit cast of str to unsigned integer

pitrou opened a new pull request #9912:
URL: https://github.com/apache/arrow/pull/9912


   Ensure that `pa.array(['5'], type='uint32')` raises an exception.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorisvandenbossche commented on pull request #9912: ARROW-9451: [Python] Refuse implicit cast of str to unsigned integer

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #9912:
URL: https://github.com/apache/arrow/pull/9912#issuecomment-814358454


   Sounds good, as long as we are consistent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorisvandenbossche commented on pull request #9912: ARROW-9451: [Python] Refuse implicit cast of str to unsigned integer

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #9912:
URL: https://github.com/apache/arrow/pull/9912#issuecomment-814334946


   It's good to make this consistent for signed vs unsigned integer types. 
   But, if `pa.array(['5']).cast("int64")` works, I would maybe also expect `pa.array(['5'], type="int64")` to work (eg in numpy both work). Now, that would be a much bigger change I suppose, I am certainly fine with making it more strict.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9912: ARROW-9451: [Python] Refuse implicit cast of str to unsigned integer

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9912:
URL: https://github.com/apache/arrow/pull/9912#issuecomment-814493867


   https://issues.apache.org/jira/browse/ARROW-9451


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #9912: ARROW-9451: [Python] Refuse implicit cast of str to unsigned integer

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9912:
URL: https://github.com/apache/arrow/pull/9912#issuecomment-814340103


   I'm not fond of lax conversions. Much better to have people explicitly cast if they want to, IMHO.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou closed pull request #9912: ARROW-9451: [Python] Refuse implicit cast of str to unsigned integer

Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #9912:
URL: https://github.com/apache/arrow/pull/9912


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org