You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by rednaxelafx <gi...@git.apache.org> on 2018/04/13 00:32:34 UTC

[GitHub] spark issue #20772: [SPARK-23628][SQL] calculateParamLength should not retur...

Github user rednaxelafx commented on the issue:

    https://github.com/apache/spark/pull/20772
  
    Just wanna leave a note here that the Janino side of the bug has been fixed:
    https://github.com/janino-compiler/janino/pull/46#issuecomment-380799160
    https://github.com/janino-compiler/janino/commit/a373ac9bb6d28d51dccb7421ea046d73809d7ce2
    With this fix, Janino will correctly throw an exception upon invalid parameter size instead of silently allowing it to pass compilation (which leads to ClassFormatError later when the generated class is loaded by the JVM).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org