You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/03 21:13:00 UTC
[jira] [Commented] (ANY23-382) Distinguish between fatal and
recoverable json-ld parsing errors
[ https://issues.apache.org/jira/browse/ANY23-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568768#comment-16568768 ]
ASF GitHub Bot commented on ANY23-382:
--------------------------------------
GitHub user HansBrende opened a pull request:
https://github.com/apache/any23/pull/113
ANY23-382 don't kill extraction on fatal json parsing errors
mvn clean test -> all tests passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HansBrende/any23 ANY23-382
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/any23/pull/113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #113
----
commit 837f92b9167d7944dbc88a965d6e17cf22b375e0
Author: Hans <fi...@...>
Date: 2018-08-03T21:06:15Z
ANY23-382 don't kill extraction on fatal json parsing errors
----
> Distinguish between fatal and recoverable json-ld parsing errors
> ----------------------------------------------------------------
>
> Key: ANY23-382
> URL: https://issues.apache.org/jira/browse/ANY23-382
> Project: Apache Any23
> Issue Type: Bug
> Components: extractors
> Affects Versions: 2.3
> Reporter: Hans Brende
> Priority: Major
> Fix For: 2.3
>
>
> I've fixed several recoverable json-ld parsing errors, but there are also errors of the (probably) non-recoverable kind, e.g.,
> {noformat}
> com.fasterxml.jackson.core.JsonParseException: Unexpected end-of-input: was expecting closing quote for a string value
> at [Source: java.io.BufferedReader@36bc415e; line: 1, column: 33786]
> at com.fasterxml.jackson.core.JsonParser._constructError(JsonParser.java:1369)
> at com.fasterxml.jackson.core.base.ParserMinimalBase._reportError(ParserMinimalBase.java:532)
> at com.fasterxml.jackson.core.base.ParserMinimalBase._reportInvalidEOF(ParserMinimalBase.java:465)
> at com.fasterxml.jackson.core.json.ReaderBasedJsonParser._finishString2(ReaderBasedJsonParser.java:1524)
> at com.fasterxml.jackson.core.json.ReaderBasedJsonParser._finishString(ReaderBasedJsonParser.java:1512)
> at com.fasterxml.jackson.core.json.ReaderBasedJsonParser.getText(ReaderBasedJsonParser.java:205)
> at com.fasterxml.jackson.databind.deser.std.UntypedObjectDeserializer.deserialize(UntypedObjectDeserializer.java:59)
> at com.fasterxml.jackson.databind.deser.std.UntypedObjectDeserializer.mapObject(UntypedObjectDeserializer.java:225)
> at com.fasterxml.jackson.databind.deser.std.UntypedObjectDeserializer.deserialize(UntypedObjectDeserializer.java:51)
> at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:230)
> at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:207)
> at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:23)
> at com.fasterxml.jackson.databind.ObjectMapper._readValue(ObjectMapper.java:2860)
> at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:1569)
> at com.fasterxml.jackson.core.JsonParser.readValueAs(JsonParser.java:1276)
> at com.github.jsonldjava.utils.JsonUtils.fromJsonParser(JsonUtils.java:194)
> at com.github.jsonldjava.utils.JsonUtils.fromReader(JsonUtils.java:173)
> at com.github.jsonldjava.utils.JsonUtils.fromInputStream(JsonUtils.java:154)
> at com.github.jsonldjava.utils.JsonUtils.fromInputStream(JsonUtils.java:111)
> at org.eclipse.rdf4j.rio.jsonld.JSONLDParser.parse(JSONLDParser.java:71) ... 13 more
> {noformat}
> caused by a truncated document, or:
> {noformat}
> com.fasterxml.jackson.core.JsonParseException: Unexpected character ('"' (code 34)): was expecting comma to separate OBJECT entries
> at [Source: java.io.BufferedReader@591fd34d; line: 1, column: 230]
> at com.fasterxml.jackson.core.JsonParser._constructError(JsonParser.java:1369)
> at com.fasterxml.jackson.core.base.ParserMinimalBase._reportError(ParserMinimalBase.java:532)
> at com.fasterxml.jackson.core.base.ParserMinimalBase._reportUnexpectedChar(ParserMinimalBase.java:453)
> at com.fasterxml.jackson.core.json.ReaderBasedJsonParser.nextToken(ReaderBasedJsonParser.java:590)
> at com.fasterxml.jackson.databind.deser.std.UntypedObjectDeserializer.mapObject(UntypedObjectDeserializer.java:226)
> at com.fasterxml.jackson.databind.deser.std.UntypedObjectDeserializer.deserialize(UntypedObjectDeserializer.java:51)
> at com.fasterxml.jackson.databind.deser.std.UntypedObjectDeserializer.mapArray(UntypedObjectDeserializer.java:172)
> at com.fasterxml.jackson.databind.deser.std.UntypedObjectDeserializer.deserialize(UntypedObjectDeserializer.java:53)
> at com.fasterxml.jackson.databind.deser.std.MapDeserializer._readAndBindStringMap(MapDeserializer.java:432)
> at com.fasterxml.jackson.databind.deser.std.MapDeserializer.deserialize(MapDeserializer.java:314)
> at com.fasterxml.jackson.databind.deser.std.MapDeserializer.deserialize(MapDeserializer.java:26)
> at com.fasterxml.jackson.databind.ObjectMapper._readValue(ObjectMapper.java:2860)
> at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:1569)
> at com.fasterxml.jackson.core.JsonParser.readValueAs(JsonParser.java:1276)
> at com.github.jsonldjava.utils.JsonUtils.fromJsonParser(JsonUtils.java:196)
> at com.github.jsonldjava.utils.JsonUtils.fromReader(JsonUtils.java:173)
> at com.github.jsonldjava.utils.JsonUtils.fromInputStream(JsonUtils.java:154)
> at com.github.jsonldjava.utils.JsonUtils.fromInputStream(JsonUtils.java:111)
> at org.eclipse.rdf4j.rio.jsonld.JSONLDParser.parse(JSONLDParser.java:71) ... 13 more
> {noformat}
> caused by the following JSON:
> {noformat}
> {
> "@context": "http://schema.org",
> "@type": "Organization",
> "url": "http://osl.ugr.es",
> "contactPoint": [{
> "@type": "ContactPoint",
> "email": "osl@ugr.es",
> "name": "Jornadas de Software Libre"
> "contactType": "Organizing committee",
> "url": "http://osl.ugr.es":
> }]
> }
> {noformat}
> Errors of the recoverable kind should be fixed, whereas errors of the non-recoverable kind should be reported as fatal errors without causing the rest of the extraction process to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)