You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/08/14 02:45:12 UTC
[GitHub] codecov-io commented on issue #2250: Fix Issue #1713. Add support
for log4j2. Team4
codecov-io commented on issue #2250: Fix Issue #1713. Add support for log4j2. Team4
URL: https://github.com/apache/incubator-dubbo/pull/2250#issuecomment-412735938
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2250?src=pr&el=h1) Report
> Merging [#2250](https://codecov.io/gh/apache/incubator-dubbo/pull/2250?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/1c16f78036b96582166c194d6142436399a1ce5a?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2250 +/- ##
============================================
- Coverage 54.57% 54.31% -0.26%
+ Complexity 5156 5153 -3
============================================
Files 568 570 +2
Lines 25019 25116 +97
Branches 4456 4471 +15
============================================
- Hits 13655 13643 -12
- Misses 9323 9429 +106
- Partials 2041 2044 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2250?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/dubbo/common/logger/LoggerFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2250/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbG9nZ2VyL0xvZ2dlckZhY3RvcnkuamF2YQ==) | `52.94% <0%> (-5.76%)` | `10 <0> (ø)` | |
| [...pache/dubbo/common/logger/log4j2/Log4j2Logger.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2250/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbG9nZ2VyL2xvZzRqMi9Mb2c0ajJMb2dnZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ubbo/common/logger/log4j2/Log4j2LoggerAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2250/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbG9nZ2VyL2xvZzRqMi9Mb2c0ajJMb2dnZXJBZGFwdGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2250/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `42.25% <0%> (-11.27%)` | `15% <0%> (-1%)` | |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2250/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NoYW5uZWxXcmFwcGVkSW52b2tlci5qYXZh) | `41.66% <0%> (-8.34%)` | `3% <0%> (ø)` | |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2250/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9JbnZva2VUZWxuZXRIYW5kbGVyLmphdmE=) | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2250/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `85.71% <0%> (+10.71%)` | `10% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2250?src=pr&el=footer). Last update [1c16f78...0e2928e](https://codecov.io/gh/apache/incubator-dubbo/pull/2250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org