You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/04 12:06:15 UTC
[GitHub] [spark] maropu commented on a change in pull request #32430: [SPARK-35133][SQL] Explain codegen works with AQE
maropu commented on a change in pull request #32430:
URL: https://github.com/apache/spark/pull/32430#discussion_r625724495
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -197,7 +198,14 @@ class QueryExecution(
queryExecution.toString(maxFields, append)
case CodegenMode =>
try {
- org.apache.spark.sql.execution.debug.writeCodegen(append, queryExecution.executedPlan)
+ queryExecution.executedPlan match {
Review comment:
How about handling the AQE node in the `writeCodegen` side instead? That way, `debugCodegen` can support it, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org