You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/01 18:40:09 UTC
[GitHub] [shardingsphere] harikesh409 opened a new pull request, #21309: Added testcases for DataSourceState
harikesh409 opened a new pull request, #21309:
URL: https://github.com/apache/shardingsphere/pull/21309
Fixes #21015.
Changes proposed in this pull request:
- Added testcases for DataSourceState
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have passed maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21309: Added testcases for DataSourceState
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21309:
URL: https://github.com/apache/shardingsphere/pull/21309#issuecomment-1264536353
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21309?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21309](https://codecov.io/gh/apache/shardingsphere/pull/21309?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0451c33) into [master](https://codecov.io/gh/apache/shardingsphere/commit/1da4d706220459308d89548712341812f5687137?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1da4d70) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #21309 +/- ##
============================================
+ Coverage 61.62% 61.63% +0.01%
- Complexity 2499 2500 +1
============================================
Files 4084 4085 +1
Lines 56480 56483 +3
Branches 7504 7504
============================================
+ Hits 34803 34812 +9
+ Misses 18758 18752 -6
Partials 2919 2919
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...fig/swapper/mode/YamlModeConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/21309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9zd2FwcGVyL21vZGUvWWFtbE1vZGVDb25maWd1cmF0aW9uU3dhcHBlci5qYXZh) | `45.45% <0.00%> (-4.55%)` | :arrow_down: |
| [...ervice/config/global/GlobalRulePersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/21309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWV0YWRhdGEvcGVyc2lzdC9zZXJ2aWNlL2NvbmZpZy9nbG9iYWwvR2xvYmFsUnVsZVBlcnNpc3RTZXJ2aWNlLmphdmE=) | `23.07% <0.00%> (-4.20%)` | :arrow_down: |
| [...ler/distsql/ral/queryable/ShowModeInfoHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/21309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3F1ZXJ5YWJsZS9TaG93TW9kZUluZm9IYW5kbGVyLmphdmE=) | `75.00% <0.00%> (-2.78%)` | :arrow_down: |
| [...mespace/parser/DataSourceBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/21309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWpkYmMtY29yZS1zcHJpbmctbmFtZXNwYWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcHJpbmcvbmFtZXNwYWNlL3BhcnNlci9EYXRhU291cmNlQmVhbkRlZmluaXRpb25QYXJzZXIuamF2YQ==) | `87.50% <0.00%> (-0.60%)` | :arrow_down: |
| [.../mode/metadata/persist/MetaDataPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/21309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWV0YWRhdGEvcGVyc2lzdC9NZXRhRGF0YVBlcnNpc3RTZXJ2aWNlLmphdmE=) | `65.11% <0.00%> (ø)` | |
| [...gsphere/dialect/exception/SQLDialectException.java](https://codecov.io/gh/apache/shardingsphere/pull/21309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlhbGVjdC1leGNlcHRpb24vc2hhcmRpbmdzcGhlcmUtZGlhbGVjdC1leGNlcHRpb24tY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlhbGVjdC9leGNlcHRpb24vU1FMRGlhbGVjdEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ol/mysql/constant/MySQLNewParametersBoundFlag.java](https://codecov.io/gh/apache/shardingsphere/pull/21309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtbXlzcWwtcHJvdG9jb2wvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL2NvbnN0YW50L015U1FMTmV3UGFyYW1ldGVyc0JvdW5kRmxhZy5qYXZh) | `100.00% <0.00%> (ø)` | |
| [...ervice/config/global/PropertiesPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/21309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWV0YWRhdGEvcGVyc2lzdC9zZXJ2aWNlL2NvbmZpZy9nbG9iYWwvUHJvcGVydGllc1BlcnNpc3RTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...otocol/mysql/exception/MySQLProtocolException.java](https://codecov.io/gh/apache/shardingsphere/pull/21309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtbXlzcWwtcHJvdG9jb2wvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL2V4Y2VwdGlvbi9NeVNRTFByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `100.00% <0.00%> (ø)` | |
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/21309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `42.85% <0.00%> (+42.85%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/shardingsphere/pull/21309/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #21309: Added testcases for DataSourceState
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #21309:
URL: https://github.com/apache/shardingsphere/pull/21309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org