You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/08/11 07:45:39 UTC
[GitHub] [zeppelin] Reamer opened a new pull request #3875: [ZEPPELIN-4989] Update to Maven resolver
Reamer opened a new pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875
### What is this PR for?
This PR updates to the aether to maven resolver.
### What type of PR is it?
- Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-4989
### How should this be tested?
* Travis-CI: https://travis-ci.org/github/Reamer/zeppelin/builds/716824269
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Leemoonsoo commented on pull request #3875: [ZEPPELIN-4989] Update to Maven resolver
Posted by GitBox <gi...@apache.org>.
Leemoonsoo commented on pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875#issuecomment-672567308
Looks like [zeppelin-distribution/src/bin_license/LICENSE](https://github.com/apache/zeppelin/blob/master/zeppelin-distribution/src/bin_license/LICENSE) and [zeppelin-distribution/src/bin_license/licenses/LICENSE-bcprov-jdk15on-1.51](https://github.com/apache/zeppelin/blob/master/zeppelin-distribution/src/bin_license/licenses/LICENSE-bcprov-jdk15on-1.51) need to be updated as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #3875: [ZEPPELIN-4989] Update to Maven resolver
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875#issuecomment-698233281
This PR is ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Leemoonsoo commented on pull request #3875: [ZEPPELIN-4989] Update to Maven resolver
Posted by GitBox <gi...@apache.org>.
Leemoonsoo commented on pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875#issuecomment-674909677
Thank @Reamer for working on this. The changes are looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #3875: [ZEPPELIN-4989] Update to Maven resolver
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875#issuecomment-706950674
If there are no further comments, I will merge this PR into Master and Branch-0.9 on Wednesday (14.10.2020)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #3875: [ZEPPELIN-4989] Update to Maven resolver
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875#issuecomment-672748678
Hi @Leemoonsoo,
I did not touch the dependency org.bouncycastle:bcpkix-jdk15on, but I can check the license.
Do we have a script to check the licenses or is everything handmade?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #3875: [ZEPPELIN-4989] Update to Maven resolver
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875#issuecomment-696016120
My problem is solved after #3914. The cause is still unknown to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #3875: [ZEPPELIN-4989] Update to Maven resolver
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875#issuecomment-698233281
This PR is ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer edited a comment on pull request #3875: [ZEPPELIN-4989] Update to Maven resolver
Posted by GitBox <gi...@apache.org>.
Reamer edited a comment on pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875#issuecomment-674787680
Hi @Leemoonsoo
I updated the license file. Thanks for your review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Leemoonsoo commented on pull request #3875: [ZEPPELIN-4989] Update to Maven resolver
Posted by GitBox <gi...@apache.org>.
Leemoonsoo commented on pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875#issuecomment-672931512
@Reamer You're right. bcprov-jdk15on-1.51 is untouched.
Unfortunately, LICENSE file is handmade.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer edited a comment on pull request #3875: [ZEPPELIN-4989] Update to Maven resolver
Posted by GitBox <gi...@apache.org>.
Reamer edited a comment on pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875#issuecomment-698233281
This PR is now ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #3875: [ZEPPELIN-4989] Update to Maven resolver
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875#issuecomment-696016120
My problem is solved after #3914. The cause is still unknown to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #3875: [ZEPPELIN-4989] Update to Maven resolver
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875#issuecomment-675329068
I notice a strange behaviour with the `zeppelin-interpreter-shaded.jar`. With this PR, `org/apache/commons/logging/` is now part of the jar
To reproduce:
- Checkout this PR
- Run Maven `mvn clean package -DskipTests -am -pl zeppelin-interpreter-shaded`
- Take a look into `zeppelin-interpreter-shaded/target/zeppelin-interpreter-shaded-0.9.0-SNAPSHOT.jar`
```
0 Defl:N 2 0% 2020-08-18 09:53 00000000 org/apache/commons/logging/
0 Defl:N 2 0% 2020-08-18 09:53 00000000 org/apache/commons/logging/impl/
2063 Defl:N 628 70% 2020-08-18 09:53 9cb659ff org/apache/commons/logging/impl/NoOpLog.class
1097 Defl:N 589 46% 2020-08-18 09:53 33ccd884 org/apache/commons/logging/impl/SimpleLog$1.class
9385 Defl:N 4173 56% 2020-08-18 09:53 8147c2bb org/apache/commons/logging/impl/SimpleLog.class
3258 Defl:N 1157 65% 2020-08-18 09:53 b06f724a org/apache/commons/logging/impl/SLF4JLocationAwareLog.class
2999 Defl:N 1061 65% 2020-08-18 09:53 bdd4455d org/apache/commons/logging/impl/SLF4JLog.class
3983 Defl:N 1829 54% 2020-08-18 09:53 43798863 org/apache/commons/logging/impl/SLF4JLogFactory.class
479 Defl:N 263 45% 2020-08-18 09:53 38ec5139 org/apache/commons/logging/Log.class
1298 Defl:N 664 49% 2020-08-18 09:53 d5b8f550 org/apache/commons/logging/LogConfigurationException.class
4828 Defl:N 1792 63% 2020-08-18 09:53 c89451e3 org/apache/commons/logging/LogFactory.class
```
**I need some help here, because I don't know why this is happening.**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer edited a comment on pull request #3875: [ZEPPELIN-4989] Update to Maven resolver
Posted by GitBox <gi...@apache.org>.
Reamer edited a comment on pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875#issuecomment-698233281
This PR is now ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #3875: [ZEPPELIN-4989] Update to Maven resolver
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875#issuecomment-674787680
Hi @Leemoonsoo
I updated to License file. Thanks for your review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #3875: [ZEPPELIN-4989] Update to Maven resolver
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org