You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/02/19 22:19:06 UTC

[GitHub] mikewalch commented on a change in pull request #967: Fixed code quality issues found by lgtm.com

mikewalch commented on a change in pull request #967: Fixed code quality issues found by lgtm.com
URL: https://github.com/apache/accumulo/pull/967#discussion_r258254685
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooLock.java
 ##########
 @@ -399,9 +399,7 @@ public synchronized void process(WatchedEvent event) {
       } catch (Exception ex) {
         if (lock != null || asyncLock != null) {
           lockWatcher.unableToMonitorLockNode(ex);
-          log.error(
-              "Error resetting watch on ZooLock " + lock == null ? asyncLock : lock + " " + event,
-              ex);
+          log.error("Error resetting watch on ZooLock " + lock + " " + event, ex);
 
 Review comment:
   `lock` can be never be null due to if statement.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services