[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #13073: [pulsar-broker] Support roll-over ledgers for inactive topics

[GitBox <gi...@apache.org>]

michaeljmarshall commented on a change in pull request #13073:
URL: https://github.com/apache/pulsar/pull/13073#discussion_r803194723



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java
##########
@@ -139,6 +139,8 @@ public synchronized void updateStats(
                                 // this task: helps to activate inactive-backlog-cursors which have caught up and
                                 // connected, also deactivate active-backlog-cursors which has backlog
                                 topic.checkBackloggedCursors();
+                                // check if topic is inactive and require ledger rollover
+                                ((PersistentTopic) topic).checkInactiveLedgers();

Review comment:
       It's fine if we want to leave it as is, but as it stands, the frequency of this method is determined by the broker config for `statsUpdateFrequencyInSecs`. In my view, that is unexpected coupling.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org