You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by wangdongxun <gi...@git.apache.org> on 2016/09/29 16:24:12 UTC
[GitHub] commons-lang pull request #194: add isAllBlank,isNotAllBlank method for Stri...
GitHub user wangdongxun opened a pull request:
https://github.com/apache/commons-lang/pull/194
add isAllBlank,isNotAllBlank method for String "null" is also blank
add isAllBlank,isNotAllBlank method for String "null" is also blank
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wangdongxun/commons-lang master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/194.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #194
----
commit 47d430dd95fb988c9a0ce3b9b6616f3b28a18cb9
Author: wangdongxun <wa...@qq.com>
Date: 2016-09-29T16:20:33Z
add isAllBlank,isNotAllBlank method for String "null" is also blank
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #194: add isAllBlank,isNotAllBlank method for String "nul...
Posted by wangdongxun <gi...@git.apache.org>.
Github user wangdongxun commented on the issue:
https://github.com/apache/commons-lang/pull/194
if("null".equals(lowerCase("Null"))){
return true;
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #194: add isAllBlank,isNotAllBlank method for String "nul...
Posted by wangdongxun <gi...@git.apache.org>.
Github user wangdongxun commented on the issue:
https://github.com/apache/commons-lang/pull/194
Thank you for your reply @kinow @PascalSchumacher @britter
I feel very honore to receive your reply. I completely agree with @PascalSchumacher . You are right!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #194: add isAllBlank,isNotAllBlank method for String "nul...
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/194
Thanks for your contribution @wangdongxun !
>The method would be very confusing, as the String "null" is not all bank.
Agree with @PascalSchumacher . Adding this could indeed be very confusing. Future requests could ask for "'null'" (with single quotes inside), or "NULL", etc. Easier done with two calls as @PascalSchumacher suggested IMO.
Unfortunately -1 as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #194: add isAllBlank,isNotAllBlank method for String "nul...
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/194
Likewise @wangdongxun :-) are you albe to close this pull request? Otherwise I believe there is some integration in our infrastructure to let us close it.
Please do not hesitate to submit other pull requests, issues or comment in our mailing lists.
Thank you
Bruno
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #194: add isAllBlank,isNotAllBlank method for Stri...
Posted by wangdongxun <gi...@git.apache.org>.
Github user wangdongxun closed the pull request at:
https://github.com/apache/commons-lang/pull/194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #194: add isAllBlank,isNotAllBlank method for String "nul...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/194
Thanks for the pull request.
The method body can be shortened to `StringUtils.isBlank(cs) || StringUtils.equalsIgnoreCase(cs, "null")`.
The method would be very confusing, as the String `"null"` is not all bank.
I'm sorry, but I'm -1 to adding this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #194: add isAllBlank,isNotAllBlank method for String "nul...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/194
[](https://coveralls.io/builds/8114697)
Coverage decreased (-0.04%) to 93.498% when pulling **47d430dd95fb988c9a0ce3b9b6616f3b28a18cb9 on wangdongxun:master** into **86a59601b570585dcb7a1ce3d1ccc8e16008f53a on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #194: add isAllBlank,isNotAllBlank method for String "nul...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/194
@wangdongxun thanks for this PR, but I don't see this as a feature in `StringUtils`. Can you elaborate some more what use case you have for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---