[GitHub] [james-site] jeantil commented on a change in pull request #13: [JAMES-3226] drops unused ui-bundle

[GitBox <gi...@apache.org>]

jeantil commented on a change in pull request #13:
URL: https://github.com/apache/james-site/pull/13#discussion_r606705723



##########
File path: doc-sites/package-lock.json
##########
@@ -5,29 +5,37 @@
   "requires": true,

Review comment:
       
   According to the [documentation](https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json)
   ```
   package-lock.json is automatically generated for any operations where npm modifies either the node_modules tree, or package.json. It describes the exact tree that was generated, such that subsequent installs are able to generate identical trees, regardless of intermediate dependency updates.
   ```
   
   So we do need to commit both package.json and package.lock.json




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org