[GitHub] [hive] kasakrisz commented on pull request #4122: HIVE-27145: Use StrictMath for remaining Math functions as followup o…

["kasakrisz (via GitHub)" <gi...@apache.org>]

kasakrisz commented on PR #4122:
URL: https://github.com/apache/hive/pull/4122#issuecomment-1488093652

   @rbalamohan 
   IIUC `Math` implementation of functions affected by this PR may exploit specific microprocessor instructions if available in that platform which gives a better performance but the default implementation just calls the `StrictMath` version.
   The cost of the performance boost is precision.
   
   Example from the PR: 
   `Degrees(cdecimal1)`
   ```
   -6844.522849943508
   ```
   vs
   ```
   -6844.522849944	
   ```
   
   Should we give up possible performance benefits to favor precision? Could you please share your thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org