You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Pavel Afremov (JIRA)" <ji...@apache.org> on 2007/10/25 20:26:50 UTC
[jira] Created: (HARMONY-5024) [drlvm] Register for Magic Helpers
[drlvm] Register for Magic Helpers
----------------------------------
Key: HARMONY-5024
URL: https://issues.apache.org/jira/browse/HARMONY-5024
Project: Harmony
Issue Type: New Feature
Reporter: Pavel Afremov
Register for Magic Helpers implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5024) [drlvm][helper] Register for Magic
Helpers
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543018 ]
Mikhail Fursov commented on HARMONY-5024:
-----------------------------------------
Pavel P., the changes you proposed are committed with revision 595613
> [drlvm][helper] Register for Magic Helpers
> ------------------------------------------
>
> Key: HARMONY-5024
> URL: https://issues.apache.org/jira/browse/HARMONY-5024
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Mikhail Fursov
> Attachments: MagicHelperRegis.patch, MagicHelperRegis.patch, MagicHelperRegis.patch, registry.diff
>
>
> Register for Magic Helpers implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5024) [drlvm][helper] Register for Magic
Helpers
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543002 ]
Pavel Pervov commented on HARMONY-5024:
---------------------------------------
1) Helpers without class and method names with only a descriptor look... peculiar. Why such methods exist?
2) In init_magic_helper: change DIE message: "Exception raised while initializing helper class " << magic_helper_class->get_name()->bytes
3) It may be good to print out exception reported in (1)
4) Do I understand correctly that load_magic_helper_class and init_magic_helper_class should be both static?
5) Why have you changed hierarchy of helper inliners into one class?
6) Why helper inlining is turned off for x86-64? Do we support magics on x86-64 yet?
> [drlvm][helper] Register for Magic Helpers
> ------------------------------------------
>
> Key: HARMONY-5024
> URL: https://issues.apache.org/jira/browse/HARMONY-5024
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Mikhail Fursov
> Attachments: MagicHelperRegis.patch, MagicHelperRegis.patch, MagicHelperRegis.patch, registry.diff
>
>
> Register for Magic Helpers implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5024) [drlvm] Register for Magic Helpers
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov updated HARMONY-5024:
-----------------------------------
Component/s: DRLVM
> [drlvm] Register for Magic Helpers
> ----------------------------------
>
> Key: HARMONY-5024
> URL: https://issues.apache.org/jira/browse/HARMONY-5024
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Pavel Afremov
>
> Register for Magic Helpers implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5024) [drlvm][helper] Register for Magic
Helpers
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543013 ]
Mikhail Fursov commented on HARMONY-5024:
-----------------------------------------
Pavel, here are the answers
1) The location of the implementation of a helper can be changed (gc_gen, gc_cc...). But it's signature can't be. This is the reason to encode the signature as a part of helper specification.
2) OK
3) what is (1) ?
4) Yes
5) If you ask about JIT code these are preliminary changes. I'm going to remove all opcode/helper specific code from helper_inliner.cpp with the next patch. With this JIRA I just turned JIT to work with VM's registry.
6) We do support all helpers except (instanceof,checkcast and ldinterface) on x86_64. I'm going to check why GC helpers are off.
7) You will have an assertion in JIT in debug mode if a class of a helper is not initialized
Pavel,
I've already committed the patch, but not all of you proposals are in commit, because I read your message later.
I'm going to commit all of your proposals with the next minor patch.
> [drlvm][helper] Register for Magic Helpers
> ------------------------------------------
>
> Key: HARMONY-5024
> URL: https://issues.apache.org/jira/browse/HARMONY-5024
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Mikhail Fursov
> Attachments: MagicHelperRegis.patch, MagicHelperRegis.patch, MagicHelperRegis.patch, registry.diff
>
>
> Register for Magic Helpers implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5024) [drlvm][helper] Register for Magic
Helpers
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Fursov resolved HARMONY-5024.
-------------------------------------
Resolution: Fixed
committed revision 595607
> [drlvm][helper] Register for Magic Helpers
> ------------------------------------------
>
> Key: HARMONY-5024
> URL: https://issues.apache.org/jira/browse/HARMONY-5024
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Mikhail Fursov
> Attachments: MagicHelperRegis.patch, MagicHelperRegis.patch, MagicHelperRegis.patch, registry.diff
>
>
> Register for Magic Helpers implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5024) [drlvm][helper] Register for Magic
Helpers
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov closed HARMONY-5024.
----------------------------------
> [drlvm][helper] Register for Magic Helpers
> ------------------------------------------
>
> Key: HARMONY-5024
> URL: https://issues.apache.org/jira/browse/HARMONY-5024
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Mikhail Fursov
> Attachments: MagicHelperRegis.patch, MagicHelperRegis.patch, MagicHelperRegis.patch, registry.diff
>
>
> Register for Magic Helpers implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5024) [drlvm][helper] Register for Magic
Helpers
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Fursov updated HARMONY-5024:
------------------------------------
Attachment: registry.diff
registry.diff: making JIT use VM registry
VM patch is also included. Please review, I'm going to commit it tomorrow
> [drlvm][helper] Register for Magic Helpers
> ------------------------------------------
>
> Key: HARMONY-5024
> URL: https://issues.apache.org/jira/browse/HARMONY-5024
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Mikhail Fursov
> Attachments: MagicHelperRegis.patch, MagicHelperRegis.patch, MagicHelperRegis.patch, registry.diff
>
>
> Register for Magic Helpers implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5024) [drlvm][helper] Register for Magic
Helpers
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov updated HARMONY-5024:
-----------------------------------
Summary: [drlvm][helper] Register for Magic Helpers (was: [drlvm] Register for Magic Helpers)
> [drlvm][helper] Register for Magic Helpers
> ------------------------------------------
>
> Key: HARMONY-5024
> URL: https://issues.apache.org/jira/browse/HARMONY-5024
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Mikhail Fursov
> Attachments: MagicHelperRegis.patch, MagicHelperRegis.patch
>
>
> Register for Magic Helpers implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5024) [drlvm] Register for Magic Helpers
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov updated HARMONY-5024:
-----------------------------------
Attachment: MagicHelperRegis.patch
Full file.
> [drlvm] Register for Magic Helpers
> ----------------------------------
>
> Key: HARMONY-5024
> URL: https://issues.apache.org/jira/browse/HARMONY-5024
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Pavel Afremov
> Attachments: MagicHelperRegis.patch, MagicHelperRegis.patch
>
>
> Register for Magic Helpers implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5024) [drlvm] Register for Magic Helpers
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Fursov reassigned HARMONY-5024:
---------------------------------------
Assignee: Mikhail Fursov
> [drlvm] Register for Magic Helpers
> ----------------------------------
>
> Key: HARMONY-5024
> URL: https://issues.apache.org/jira/browse/HARMONY-5024
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Mikhail Fursov
> Attachments: MagicHelperRegis.patch, MagicHelperRegis.patch
>
>
> Register for Magic Helpers implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5024) [drlvm][helper] Register for Magic
Helpers
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543049 ]
Pavel Pervov commented on HARMONY-5024:
---------------------------------------
Re (3): it should link to second bullet. At one moent of editing I renumbered the list, but forgot to change links.
> [drlvm][helper] Register for Magic Helpers
> ------------------------------------------
>
> Key: HARMONY-5024
> URL: https://issues.apache.org/jira/browse/HARMONY-5024
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Mikhail Fursov
> Attachments: MagicHelperRegis.patch, MagicHelperRegis.patch, MagicHelperRegis.patch, registry.diff
>
>
> Register for Magic Helpers implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5024) [drlvm] Register for Magic Helpers
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov updated HARMONY-5024:
-----------------------------------
Attachment: MagicHelperRegis.patch
Initial version of implementation of Register for Magic Helpers
> [drlvm] Register for Magic Helpers
> ----------------------------------
>
> Key: HARMONY-5024
> URL: https://issues.apache.org/jira/browse/HARMONY-5024
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Pavel Afremov
> Attachments: MagicHelperRegis.patch
>
>
> Register for Magic Helpers implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5024) [drlvm][helper] Register for Magic
Helpers
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543004 ]
Pavel Pervov commented on HARMONY-5024:
---------------------------------------
7) It can be assumed that a class of a helper method is initialized. It can be asserted in the code instead of runtime check.
> [drlvm][helper] Register for Magic Helpers
> ------------------------------------------
>
> Key: HARMONY-5024
> URL: https://issues.apache.org/jira/browse/HARMONY-5024
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Mikhail Fursov
> Attachments: MagicHelperRegis.patch, MagicHelperRegis.patch, MagicHelperRegis.patch, registry.diff
>
>
> Register for Magic Helpers implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5024) [drlvm][helper] Register for Magic
Helpers
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov updated HARMONY-5024:
-----------------------------------
Attachment: MagicHelperRegis.patch
Second "full functional" version of magic helper register. DRL VM and both GC_CC and GC_Gen were modified to register their helpers. So JIT can use them starting now.
> [drlvm][helper] Register for Magic Helpers
> ------------------------------------------
>
> Key: HARMONY-5024
> URL: https://issues.apache.org/jira/browse/HARMONY-5024
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Mikhail Fursov
> Attachments: MagicHelperRegis.patch, MagicHelperRegis.patch, MagicHelperRegis.patch
>
>
> Register for Magic Helpers implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.