You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/03/12 23:44:04 UTC
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5627: Add support for Centos8 and optionally including openssl
zrhoffman commented on a change in pull request #5627:
URL: https://github.com/apache/trafficcontrol/pull/5627#discussion_r592537770
##########
File path: traffic_server/tsb/run.sh
##########
@@ -24,21 +24,31 @@ die() {
}
mkdir /opt/build
-cp -fa /opt/{src,build}/jansson
-cp -fa /opt/{src,build}/cjose
-cp -fa /opt/{src,build}/openssl
-
-# Build OpenSSL
-(
- cd /opt/build/openssl && \
- ./config --prefix=/opt/trafficserver/openssl --openssldir=/opt/trafficserver/openssl zlib && \
- make -j`nproc` && \
- make install_sw
-) || die "Failed to build OpenSSL"
-
-
-(cd /opt/build/jansson && patch -p1 < /opt/src/jansson.pic.patch && autoreconf -i && ./configure --enable-shared=no && make -j`nproc` && make install) || die "Failed to install jansson from source."
-(cd /opt/build/cjose && patch -p1 < /opt/src/cjose.pic.patch && autoreconf -i && ./configure --enable-shared=no --with-openssl=/opt/trafficserver/openssl && make -j`nproc` && make install) || die "Failed to install cjose from source."
+cp -far /opt/{src,build}/jansson
+cp -far /opt/{src,build}/cjose
Review comment:
This can be `cp -fa`
##########
File path: traffic_server/tsb/run.sh
##########
@@ -24,21 +24,31 @@ die() {
}
mkdir /opt/build
-cp -fa /opt/{src,build}/jansson
-cp -fa /opt/{src,build}/cjose
-cp -fa /opt/{src,build}/openssl
-
-# Build OpenSSL
-(
- cd /opt/build/openssl && \
- ./config --prefix=/opt/trafficserver/openssl --openssldir=/opt/trafficserver/openssl zlib && \
- make -j`nproc` && \
- make install_sw
-) || die "Failed to build OpenSSL"
-
-
-(cd /opt/build/jansson && patch -p1 < /opt/src/jansson.pic.patch && autoreconf -i && ./configure --enable-shared=no && make -j`nproc` && make install) || die "Failed to install jansson from source."
-(cd /opt/build/cjose && patch -p1 < /opt/src/cjose.pic.patch && autoreconf -i && ./configure --enable-shared=no --with-openssl=/opt/trafficserver/openssl && make -j`nproc` && make install) || die "Failed to install cjose from source."
+cp -far /opt/{src,build}/jansson
+cp -far /opt/{src,build}/cjose
+
+if [ "$1" == "--with_openssl" ]; then
+ cp -far /opt/{src,build}/openssl
Review comment:
`cp -far` can be simplified to `cp -fa`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org