You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/08 11:14:13 UTC
[GitHub] [incubator-tvm] qihaitao opened a new pull request #4656: fix
topi.nn.global_pool layout="NHWC"
qihaitao opened a new pull request #4656: fix topi.nn.global_pool layout="NHWC"
URL: https://github.com/apache/incubator-tvm/pull/4656
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4656: fix
topi.nn.global_pool layout="NHWC"
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4656: fix topi.nn.global_pool layout="NHWC"
URL: https://github.com/apache/incubator-tvm/pull/4656#issuecomment-573163568
Thanks @kevinthesun @qihaitao !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4656:
fix topi.nn.global_pool layout="NHWC"
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #4656: fix topi.nn.global_pool layout="NHWC"
URL: https://github.com/apache/incubator-tvm/pull/4656#discussion_r364378931
##########
File path: topi/src/topi.cc
##########
@@ -527,7 +527,7 @@ TVM_REGISTER_GLOBAL("topi.nn.pool_grad")
TVM_REGISTER_GLOBAL("topi.nn.global_pool")
.set_body([](TVMArgs args, TVMRetValue *rv) {
*rv = nn::global_pool(args[0],
- static_cast<nn::PoolType>(static_cast<int>(args[1])));
+ static_cast<nn::PoolType>(static_cast<int>(args[1])),args[2]);
Review comment:
style : space between , and args
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request
#4656: fix topi.nn.global_pool layout="NHWC"
Posted by GitBox <gi...@apache.org>.
kevinthesun commented on a change in pull request #4656: fix topi.nn.global_pool layout="NHWC"
URL: https://github.com/apache/incubator-tvm/pull/4656#discussion_r364379927
##########
File path: topi/src/topi.cc
##########
@@ -527,7 +527,7 @@ TVM_REGISTER_GLOBAL("topi.nn.pool_grad")
TVM_REGISTER_GLOBAL("topi.nn.global_pool")
.set_body([](TVMArgs args, TVMRetValue *rv) {
*rv = nn::global_pool(args[0],
- static_cast<nn::PoolType>(static_cast<int>(args[1])));
+ static_cast<nn::PoolType>(static_cast<int>(args[1])),args[2]);
Review comment:
Please add a test case for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen merged pull request #4656: fix
topi.nn.global_pool layout="NHWC"
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #4656: fix topi.nn.global_pool layout="NHWC"
URL: https://github.com/apache/incubator-tvm/pull/4656
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services