You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/08/10 02:02:55 UTC
[GitHub] [incubator-uniffle] sfwang218 commented on pull request #152: [BUGFIX] Fix flush event bug which cause app resource delete not clean
sfwang218 commented on PR #152:
URL: https://github.com/apache/incubator-uniffle/pull/152#issuecomment-1210065492
> Em....if we remove the app after we judge whether the event is valid, some app resource still won't be deleted. I feel that this pr don't solve the problems totally.
In this case, there two situations:
1. We judge the event is valid and the 'write' method is finished, and then we remove the app. In this way, the app resource will be deleted cleanly
2. We judge the event is valid and the 'write' method is not finished, and then we remove the app. In this way, the 'write' method will throw exception, and will retry later as shown below
when the event retry, we will judge whether it is valid again as shown below
In summary, i think this pr can solve the problems totally, I don't know if I'm right, Please correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org