You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/14 16:22:55 UTC

[GitHub] [incubator-superset] kgabryje commented on pull request #11217: refactor: Implement TableView component

kgabryje commented on pull request #11217:
URL: https://github.com/apache/incubator-superset/pull/11217#issuecomment-708512595


   @nytai I added unit tests, but also changed the structure a bit. I moved `TableView` to a separate dir and extracted `TableCollection` and `Pagination` from `ListView` to a new `dataViewCommon` directory. I'd appreciate your feedback.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org