You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/19 05:25:47 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #9257: ARROW-11311: [Rust] Fixed unset_bit
jorgecarleitao opened a new pull request #9257:
URL: https://github.com/apache/arrow/pull/9257
The functions `unset_bit` and `unset_bit_raw` were toggling, not unsetting, bits, which was obviously wrong.
This PR also changes the test for `set_bit` to also make sure that it does not toggle bits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9257: ARROW-11311: [Rust] Fixed unset_bit
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9257:
URL: https://github.com/apache/arrow/pull/9257
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9257: ARROW-11311: [Rust] Fixed unset_bit
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9257:
URL: https://github.com/apache/arrow/pull/9257#issuecomment-762614815
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9257?src=pr&el=h1) Report
> Merging [#9257](https://codecov.io/gh/apache/arrow/pull/9257?src=pr&el=desc) (035dbaf) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9257?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9257 +/- ##
=======================================
Coverage 81.61% 81.61%
=======================================
Files 215 215
Lines 51867 51891 +24
=======================================
+ Hits 42329 42353 +24
Misses 9538 9538
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9257?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/util/bit\_util.rs](https://codecov.io/gh/apache/arrow/pull/9257/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvdXRpbC9iaXRfdXRpbC5ycw==) | `100.00% <100.00%> (ø)` | |
| [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9257/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `91.66% <100.00%> (+0.16%)` | :arrow_up: |
| [rust/arrow/src/array/transform/fixed\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9257/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2ZpeGVkX2JpbmFyeS5ycw==) | `84.21% <0.00%> (+5.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9257?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9257?src=pr&el=footer). Last update [1401359...035dbaf](https://codecov.io/gh/apache/arrow/pull/9257?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9257: ARROW-11311: [Rust] Fixed unset_bit
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9257:
URL: https://github.com/apache/arrow/pull/9257#issuecomment-762609707
https://issues.apache.org/jira/browse/ARROW-11311
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] yordan-pavlov commented on pull request #9257: ARROW-11311: [Rust] Fixed unset_bit
Posted by GitBox <gi...@apache.org>.
yordan-pavlov commented on pull request #9257:
URL: https://github.com/apache/arrow/pull/9257#issuecomment-763146129
good spot @jorgecarleitao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org