[GitHub] GabeLoins commented on a change in pull request #5056: [Adhoc Filters] integrating dashboard filters with adhoc filters

[GitBox <gi...@apache.org>]

GabeLoins commented on a change in pull request #5056: [Adhoc Filters] integrating dashboard filters with adhoc filters
URL: https://github.com/apache/incubator-superset/pull/5056#discussion_r190074892
 
 

 ##########
 File path: superset/utils.py
 ##########
 @@ -841,3 +841,39 @@ def ensure_path_exists(path):
     except OSError as exc:
         if not (os.path.isdir(path) and exc.errno == errno.EEXIST):
             raise
+
+
+def split_adhoc_filters_into_legacy_filters(fd):
 
 Review comment:
   @michellethomas done!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org