You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pedro Marques <pe...@gmail.com> on 2013/11/01 01:19:38 UTC
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/
-----------------------------------------------------------
(Updated Nov. 1, 2013, 12:19 a.m.)
Review request for cloudstack and Hugo Trippaers.
Changes
-------
Update the diff according to code review comments.
Repository: cloudstack-git
Description
-------
Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
Diffs (updated)
-----
api/src/com/cloud/network/Network.java 49f380b
client/pom.xml 3e08a9a
client/tomcatconf/commands.properties.in e92596c
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 3df28ed
plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ApiConnectorMockito.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ProviderTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/commonContext.xml PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/contrail.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/db.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/log4j.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/mysql_db_stop.sh PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/providerContext.xml PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/publicNetworkContext.xml PRE-CREATION
plugins/pom.xml ca41dff
Diff: https://reviews.apache.org/r/14549/diff/
Testing
-------
Integration test passes.
Thanks,
Pedro Marques
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Amogh Vasekar <am...@citrix.com>.
> On Nov. 1, 2013, 4:57 p.m., Hugo Trippaers wrote:
> > commit 6b5fab2f5cd939f64b5c9c1ee8d87ca8b6f6514d
> > Author: Pedro Marques <ro...@juniper.net>
> > Date: Thu Oct 31 17:16:58 2013 -0700
> >
> > OpenContrail network plugin
> >
> > Signed-off-by: Hugo Trippaers <ht...@schubergphilis.com>
> >
Reminder -
Hi,
Can you please mark this as submmited? Thanks!
- Amogh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/#review28016
-----------------------------------------------------------
On Nov. 1, 2013, 12:19 a.m., Pedro Marques wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14549/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 12:19 a.m.)
>
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java 49f380b
> client/pom.xml 3e08a9a
> client/tomcatconf/commands.properties.in e92596c
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 3df28ed
> plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ApiConnectorMockito.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ProviderTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/commonContext.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/contrail.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/db.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/log4j.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/mysql_db_stop.sh PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/providerContext.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/publicNetworkContext.xml PRE-CREATION
> plugins/pom.xml ca41dff
>
> Diff: https://reviews.apache.org/r/14549/diff/
>
>
> Testing
> -------
>
> Integration test passes.
>
>
> Thanks,
>
> Pedro Marques
>
>
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/#review28016
-----------------------------------------------------------
Ship it!
commit 6b5fab2f5cd939f64b5c9c1ee8d87ca8b6f6514d
Author: Pedro Marques <ro...@juniper.net>
Date: Thu Oct 31 17:16:58 2013 -0700
OpenContrail network plugin
Signed-off-by: Hugo Trippaers <ht...@schubergphilis.com>
- Hugo Trippaers
On Nov. 1, 2013, 12:19 a.m., Pedro Marques wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14549/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 12:19 a.m.)
>
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java 49f380b
> client/pom.xml 3e08a9a
> client/tomcatconf/commands.properties.in e92596c
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 3df28ed
> plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ApiConnectorMockito.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ProviderTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/commonContext.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/contrail.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/db.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/log4j.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/mysql_db_stop.sh PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/providerContext.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/publicNetworkContext.xml PRE-CREATION
> plugins/pom.xml ca41dff
>
> Diff: https://reviews.apache.org/r/14549/diff/
>
>
> Testing
> -------
>
> Integration test passes.
>
>
> Thanks,
>
> Pedro Marques
>
>