You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by cakofony <gi...@git.apache.org> on 2017/12/06 21:27:55 UTC

[GitHub] logging-log4j2 pull request #137: PatternFormatter avoids identityToString u...

GitHub user cakofony opened a pull request:

    https://github.com/apache/logging-log4j2/pull/137

    PatternFormatter avoids identityToString until collisions detected

    This implementation uses an IdentityHashMap backed Set to avoid
    building a string and hashing it unnecessarily.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cakofony/logging-log4j2 pattern_formatter_dejavu

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4j2/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #137
    
----
commit 046213021eaa26602ce09fa08d5b2bef7258341a
Author: Carter Kozak <c4...@gmail.com>
Date:   2017-12-06T20:49:06Z

    PatternFormatter avoids identityToString until collisions detected
    
    This implementation uses an IdentityHashMap backed Set to avoid
    building a string and hashing it unnecessarily.

----


---

[GitHub] logging-log4j2 issue #137: PatternFormatter avoids identityToString until co...

Posted by cakofony <gi...@git.apache.org>.

Github user cakofony commented on the issue:

    https://github.com/apache/logging-log4j2/pull/137
  
    I have not yet


---

[GitHub] logging-log4j2 pull request #137: PatternFormatter avoids identityToString u...

Posted by cakofony <gi...@git.apache.org>.

Github user cakofony closed the pull request at:

    https://github.com/apache/logging-log4j2/pull/137


---

[GitHub] logging-log4j2 issue #137: PatternFormatter avoids identityToString until co...

Posted by mikaelstaldal <gi...@git.apache.org>.

Github user mikaelstaldal commented on the issue:

    https://github.com/apache/logging-log4j2/pull/137
  
    Have you made any performance testing on this?


---