You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/07/02 12:43:31 UTC

[GitHub] [incubator-shenyu] skyleaworlder opened a new pull request, #3652: [ISSUE 3513] [Part 1] (only integrated-test) Change dockerfile-maven-plugin to docker-maven-plugin

skyleaworlder opened a new pull request, #3652:
URL: https://github.com/apache/incubator-shenyu/pull/3652

   <!-- Describe your PR here; eg. Fixes #issueNo -->
   
   About #3513 
   
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [x] You submit test cases (unit or integration tests) that back your changes.
   - [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
   
   ### Change packaging plugin
   
   Former packaging plugin is [dockerfile-maven-plugin](https://github.com/spotify/dockerfile-maven), which is archived now. The new packaging plugin is [docker-maven-plugin](https://github.com/fabric8io/docker-maven-plugin).
   
   [dockerfile-maven-plugin](https://github.com/spotify/dockerfile-maven) used as:
   
   ```xml
   <plugin>
       <groupId>com.spotify</groupId>
       <artifactId>dockerfile-maven-plugin</artifactId>
       <version>${dockerfile-maven-plugin.version}</version>
       <executions>
           <execution>
               <id>shenyu-integrated-test-apache-dubbo</id>
               <goals>
                   <goal>build</goal>
               </goals>
           </execution>
       </executions>
       <configuration>
           <repository>shenyu-integrated-test-apache-dubbo</repository>
           <tag>latest</tag>
           <buildArgs>
               <APP_NAME>shenyu-integrated-test-apache-dubbo</APP_NAME>
           </buildArgs>
       </configuration>
   </plugin>
   ```
   
   [docker-maven-plugin](https://github.com/fabric8io/docker-maven-plugin) can be used as:
   
   ```xml
   <plugin>
       <groupId>io.fabric8</groupId>
       <artifactId>docker-maven-plugin</artifactId>
       <version>${docker-maven-plugin.version}</version> <!-- now is 0.41.0 -->
       <configuration>
           <images>
               <image>
                   <name>apache/shenyu-integrated-test-apache-dubbo</name> <!-- name with "repository"-->
                   <build>
                       <contextDir>${project.basedir}</contextDir> <!-- Dockerfile path -->
                   </build>
               </image>
           </images>
       </configuration>
       <executions>
           <execution>
               <id>start</id>
               <goals>
                   <goal>build</goal>
               </goals>
           </execution>
       </executions>
   </plugin>
   ```
   
   ### Test on my PC
   
   Now I use Docker Desktop on Windows 10. And the result of plugin change are listed below. (I use 2 plugins to build docker images and corresponding sizes equal)
   
   I use this mvn command:
   
   ```shell
   mvn -B clean install -Pit -DskipTests -f ./shenyu-integrated-test/pom.xml
   ```
   
   **use dockerfile-maven-plugin**:
   
   ![13)2HI 113A4%MXJ WNAP`Q](https://user-images.githubusercontent.com/45269589/177001051-6501567b-6915-4e72-96ab-6ba572df328b.png)
   
   **use docker-maven-plugin**:
   
   ![image](https://user-images.githubusercontent.com/45269589/177001146-95fa98b5-d5e5-4d0d-86b4-5f0ab9f2e800.png)
   
   ### Notice
   
   :warning: I only change packaging plugin in "integrated-test" in this PR now, for this is my first PR in apache/incubator-shenyu and I want to experience CI workflows (especially "it") for myself :)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] skyleaworlder commented on pull request #3652: [ISSUE 3513] [Part 1] (only integrated-test now) Change dockerfile-maven-plugin to docker-maven-plugin

Posted by GitBox <gi...@apache.org>.

skyleaworlder commented on PR #3652:
URL: https://github.com/apache/incubator-shenyu/pull/3652#issuecomment-1173018081

   @JooKS-me Hi! workflow has passed, and image building process listed below:
   
   ![image](https://user-images.githubusercontent.com/45269589/177026357-7958fcef-ff5c-40c5-938e-58bd214fff3d.png)
   
   ![image](https://user-images.githubusercontent.com/45269589/177026350-0a58b4a2-ac6d-4218-a3d6-4f068ec74112.png)
   
   ![image](https://user-images.githubusercontent.com/45269589/177026346-4327c41c-2a56-4cd1-a94b-77f11cf3599f.png)
   
   ![image](https://user-images.githubusercontent.com/45269589/177026339-85075e02-52cf-4ef7-9f41-8a49f66ed00b.png)
   
   ![image](https://user-images.githubusercontent.com/45269589/177026334-c03d5343-59a5-4cfd-b11e-327a77850a7d.png)
   
   ![image](https://user-images.githubusercontent.com/45269589/177026330-aeb494ab-9cc7-41b4-b8a2-8db38b759fa0.png)
   
   ![image](https://user-images.githubusercontent.com/45269589/177026324-4e27a815-b951-4772-b922-c129b4bab1d8.png)
   
   ![image](https://user-images.githubusercontent.com/45269589/177026281-a149b106-00e9-4d35-908b-515fdec63b77.png)
   
   ![image](https://user-images.githubusercontent.com/45269589/177026274-8f1eb1a5-da6b-4f4a-956c-ec1bdd9c68ea.png)
   
   ![image](https://user-images.githubusercontent.com/45269589/177026238-f1beddb2-1d8f-499a-8e66-ff400da61d15.png)
   
   Former:
   
   ![image](https://user-images.githubusercontent.com/45269589/177026842-ce15a526-dcef-4cc0-8c0e-d082368f69ea.png)
   
   I would be delighted if you can help me to check if the impact "docker-maven-plugin" did in "it" (e.g. [build (shenyu-integrated-test-alibaba-dubbo)](https://github.com/apache/incubator-shenyu/runs/7162823890?check_suite_focus=true)) reaches original expectation. ❤️ 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #3652: [ISSUE 3513] [Part 1] (only integrated-test now) Change dockerfile-maven-plugin to docker-maven-plugin

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on PR #3652:
URL: https://github.com/apache/incubator-shenyu/pull/3652#issuecomment-1172918778

   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3652?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3652](https://codecov.io/gh/apache/incubator-shenyu/pull/3652?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d46af4) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/f11c8b1ef1ab5cc055c56942358e2d71239c7062?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f11c8b1) will **decrease** coverage by `0.42%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3652      +/-   ##
   ============================================
   - Coverage     62.64%   62.21%   -0.43%     
   + Complexity     5855     5828      -27     
   ============================================
     Files           888      888              
     Lines         24730    24742      +12     
     Branches       2263     2264       +1     
   ============================================
   - Hits          15492    15394      -98     
   - Misses         7784     7904     +120     
   + Partials       1454     1444      -10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/3652?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...henyu/plugin/logging/kafka/LoggingKafkaPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcva2Fma2EvTG9nZ2luZ0thZmthUGx1Z2luLmphdmE=) | `22.72% <0.00%> (-72.73%)` | :arrow_down: |
   | [...ging/rocketmq/client/RocketMQLogCollectClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvY2xpZW50L1JvY2tldE1RTG9nQ29sbGVjdENsaWVudC5qYXZh) | `10.00% <0.00%> (-62.00%)` | :arrow_down: |
   | [...icsearch/client/ElasticSearchLogCollectClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWVsYXN0aWNzZWFyY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbG9nZ2luZy9lbGFzdGljc2VhcmNoL2NsaWVudC9FbGFzdGljU2VhcmNoTG9nQ29sbGVjdENsaWVudC5qYXZh) | `10.00% <0.00%> (-36.00%)` | :arrow_down: |
   | [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | [...etmq/handler/LoggingRocketMQPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvaGFuZGxlci9Mb2dnaW5nUm9ja2V0TVFQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `47.91% <0.00%> (-22.92%)` | :arrow_down: |
   | [...controller/ShenyuClientHttpRegistryController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TaGVueXVDbGllbnRIdHRwUmVnaXN0cnlDb250cm9sbGVyLmphdmE=) | `77.77% <0.00%> (-22.23%)` | :arrow_down: |
   | [...handler/LoggingElasticSearchPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWVsYXN0aWNzZWFyY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbG9nZ2luZy9lbGFzdGljc2VhcmNoL2hhbmRsZXIvTG9nZ2luZ0VsYXN0aWNTZWFyY2hQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `48.93% <0.00%> (-21.28%)` | :arrow_down: |
   | [...n/logging/kafka/body/LoggingServerHttpRequest.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcva2Fma2EvYm9keS9Mb2dnaW5nU2VydmVySHR0cFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [...gin/logging/kafka/kafka/KafkaLogCollectClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcva2Fma2Eva2Fma2EvS2Fma2FMb2dDb2xsZWN0Q2xpZW50LmphdmE=) | `34.69% <0.00%> (-18.37%)` | :arrow_down: |
   | [.../plugin/logging/kafka/entity/ShenyuRequestLog.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcva2Fma2EvZW50aXR5L1NoZW55dVJlcXVlc3RMb2cuamF2YQ==) | `86.20% <0.00%> (-13.80%)` | :arrow_down: |
   | ... and [54 more](https://codecov.io/gh/apache/incubator-shenyu/pull/3652/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3652?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3652?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f11c8b1...3d46af4](https://codecov.io/gh/apache/incubator-shenyu/pull/3652?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] JooKS-me merged pull request #3652: [ISSUE 3513] [Part 1] (only integrated-test now) Change dockerfile-maven-plugin to docker-maven-plugin

Posted by GitBox <gi...@apache.org>.

JooKS-me merged PR #3652:
URL: https://github.com/apache/incubator-shenyu/pull/3652


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org