You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by na...@apache.org on 2009/08/20 03:44:07 UTC

svn commit: r806019 - in /hadoop/hive/trunk: CHANGES.txt ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java ql/src/test/queries/clientnegative/input_part0_neg.q ql/src/test/results/clientnegative/input_part0_neg.q.out

Author: namit
Date: Thu Aug 20 01:44:06 2009
New Revision: 806019

URL: http://svn.apache.org/viewvc?rev=806019&view=rev
Log:
HIVE-769. Bug in partition pruner checking - bug in patch. 
(Zheng Shao via namit)


Added:
    hadoop/hive/trunk/ql/src/test/queries/clientnegative/input_part0_neg.q
    hadoop/hive/trunk/ql/src/test/results/clientnegative/input_part0_neg.q.out
Modified:
    hadoop/hive/trunk/CHANGES.txt
    hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java

Modified: hadoop/hive/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/CHANGES.txt?rev=806019&r1=806018&r2=806019&view=diff
==============================================================================
--- hadoop/hive/trunk/CHANGES.txt (original)
+++ hadoop/hive/trunk/CHANGES.txt Thu Aug 20 01:44:06 2009
@@ -44,6 +44,9 @@
     HIVE-773. Remove lzocodec import from FileSinkOperator.
     (He Yongqiang via johan)
 
+    HIVE-769. Bug in partition pruner checking - bug in patch. 
+    (Zheng Shao via namit)
+
 Release 0.4.0 -  Unreleased
 
   INCOMPATIBLE CHANGES

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java?rev=806019&r1=806018&r2=806019&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java Thu Aug 20 01:44:06 2009
@@ -199,9 +199,11 @@
     }
     // Return true in case one of the children is column expr.
     List<exprNodeDesc> children = desc.getChildren();
-    for (int i = 0; i < children.size(); i++) {
-      if (hasColumnExpr(children.get(i))) {
-        return true;
+    if (children != null) {
+      for (int i = 0; i < children.size(); i++) {
+        if (hasColumnExpr(children.get(i))) {
+          return true;
+        }
       }
     }
     // Return false otherwise

Added: hadoop/hive/trunk/ql/src/test/queries/clientnegative/input_part0_neg.q
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/test/queries/clientnegative/input_part0_neg.q?rev=806019&view=auto
==============================================================================
--- hadoop/hive/trunk/ql/src/test/queries/clientnegative/input_part0_neg.q (added)
+++ hadoop/hive/trunk/ql/src/test/queries/clientnegative/input_part0_neg.q Thu Aug 20 01:44:06 2009
@@ -0,0 +1,3 @@
+set hive.mapred.mode=strict;
+
+SELECT x.* FROM SRCPART x WHERE key = '2008-04-08';

Added: hadoop/hive/trunk/ql/src/test/results/clientnegative/input_part0_neg.q.out
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/test/results/clientnegative/input_part0_neg.q.out?rev=806019&view=auto
==============================================================================
--- hadoop/hive/trunk/ql/src/test/results/clientnegative/input_part0_neg.q.out (added)
+++ hadoop/hive/trunk/ql/src/test/results/clientnegative/input_part0_neg.q.out Thu Aug 20 01:44:06 2009
@@ -0,0 +1 @@
+FAILED: Error in semantic analysis: No Partition Predicate Found for Alias "x" Table "srcpart"