[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6900: Fix ping NFS server on ssvm-check.sh

["DaanHoogland (via GitHub)" <gi...@apache.org>]

DaanHoogland commented on code in PR #6900:
URL: https://github.com/apache/cloudstack/pull/6900#discussion_r1092078869


##########
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java:
##########
@@ -1180,9 +1182,29 @@ public boolean finalizeVirtualMachineProfile(VirtualMachineProfile profile, Depl
         s_logger.debug(String.format("Setting UseHttpsToUpload config on cmdline with [%s] value.", useHttpsToUpload));
         buf.append(" useHttpsToUpload=").append(useHttpsToUpload);
 
+        addSecondaryStorageServerAddressToBuffer(buf, secStore, vmName);

Review Comment:
   @weizhouapache @GutoVeronezi , though I think Wei's request is valid it seems to me to be out of scope for this PR and the issue it tries to solve . Shall we move this enhancement to a new PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org